Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: runtime/vm/dart_entry.cc

Issue 18209024: Correct handling of named optional parameters with noSuchMethod invocations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_entry.cc
===================================================================
--- runtime/vm/dart_entry.cc (revision 24876)
+++ runtime/vm/dart_entry.cc (working copy)
@@ -167,15 +167,22 @@
}
-bool ArgumentsDescriptor::MatchesNameAt(intptr_t index,
- const String& other) const {
+RawString* ArgumentsDescriptor::NameAt(intptr_t index) const {
const intptr_t offset = kFirstNamedEntryIndex +
(index * kNamedEntrySize) +
kNameOffset;
- return array_.At(offset) == other.raw();
+ String& result = String::Handle();
+ result ^= array_.At(offset);
+ return result.raw();
}
+bool ArgumentsDescriptor::MatchesNameAt(intptr_t index,
+ const String& other) const {
+ return NameAt(index) == other.raw();
+}
+
+
intptr_t ArgumentsDescriptor::count_offset() {
return Array::element_offset(kCountIndex);
}
« no previous file with comments | « runtime/vm/dart_entry.h ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698