Correct handling of named optional parameters with noSuchMethod invocations.

runtime/vm/dart_entry.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_entry.h"
 
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
 #include "vm/debugger.h"
 #include "vm/object_store.h"
@@ skipping 149 matching lines @@
 intptr_t ArgumentsDescriptor::Count() const {
   return Smi::CheckedHandle(array_.At(kCountIndex)).Value();
 }
 
 
 intptr_t ArgumentsDescriptor::PositionalCount() const {
   return Smi::CheckedHandle(array_.At(kPositionalCountIndex)).Value();
 }
 
 
+RawString* ArgumentsDescriptor::NameAt(intptr_t index) const {
+  const intptr_t offset = kFirstNamedEntryIndex +
+                          (index * kNamedEntrySize) +
+                          kNameOffset;
+  String& result = String::Handle();
+  result ^= array_.At(offset);
+  return result.raw();
+}
+
+
 bool ArgumentsDescriptor::MatchesNameAt(intptr_t index,
                                         const String& other) const {
   const intptr_t offset = kFirstNamedEntryIndex +
                           (index * kNamedEntrySize) +
                           kNameOffset;
   return array_.At(offset) == other.raw();

[srdjan, 2013/07/10 23:29:04]

Reuse NameAt here

[Florian Schneider, 2013/07/11 09:21:23]

Done.

 }
 
 
 intptr_t ArgumentsDescriptor::count_offset() {
   return Array::element_offset(kCountIndex);
 }
 
 
 intptr_t ArgumentsDescriptor::positional_count_offset() {
   return Array::element_offset(kPositionalCountIndex);
@@ skipping 298 matching lines @@
           String::Handle(Field::GetterName(Symbols::_id()))));
   const Function& func = Function::Handle(cls.LookupDynamicFunction(func_name));
   ASSERT(!func.IsNull());
   const Array& args = Array::Handle(Array::New(1));
   args.SetAt(0, port);
   return DartEntry::InvokeFunction(func, args);
 }
 
 
 }  // namespace dart