Issue 18089005: Fix safari browser to use Future.value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18089005: Fix safari browser to use Future.value (Closed)

Created:
7 years, 5 months ago by ricow1

Modified:
7 years, 5 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix safari browser to use Future.value Also correct type errors found by the analyzer. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24532

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -58 lines)			Patch
M	tools/test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/testing/dart/android.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	tools/testing/dart/browser_controller.dart	View	8 chunks	+21 lines, -20 lines	0 comments	Download
M	tools/testing/dart/multitest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_progress.dart	View	3 chunks	+22 lines, -20 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	4 chunks	+7 lines, -4 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tools/testing/dart/vendored_pkg/args/args.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

ricow1

7 years, 5 months ago (2013-06-27 17:07:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24532 (presubmit successful).