Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 18089005: Fix safari browser to use Future.value (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 24520)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -984,7 +984,6 @@
return argument;
}
}).toList();
- return;
}
@@ -1207,7 +1206,7 @@
String _createArgumentsLine(List<String> arguments, int timeout) {
arguments = _modifySeleniumTimeout(arguments, timeout);
- return arguments.join(' ').concat('\n');
+ return arguments.join(' ') + '\n';
}
void _reportResult() {
@@ -1762,7 +1761,9 @@
_numBrowserProcesses--;
}
eventFinishedTestCase(test_arg);
- if (test_arg is BrowserTestCase) test_arg.notifyObservers();
+ if (test_arg is BrowserTestCase) {
+ (test_arg as BrowserTestCase).notifyObservers();
+ }
oldCallback(test_arg);
_tryRunTest();
};
@@ -1789,7 +1790,9 @@
if (isTestCaseFinished(testCase)) {
testCase.completed();
eventFinishedTestCase(testCase);
- if (testCase is BrowserTestCase) testCase.notifyObservers();
+ if (testCase is BrowserTestCase) {
+ (testCase as BrowserTestCase).notifyObservers();
+ }
} else {
_tests.addFirst(testCase);
}
« no previous file with comments | « tools/testing/dart/test_progress.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698