Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: tools/testing/dart/android.dart

Issue 18089005: Fix safari browser to use Future.value (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/browser_controller.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/android.dart
===================================================================
--- tools/testing/dart/android.dart (revision 24517)
+++ tools/testing/dart/android.dart (working copy)
@@ -35,11 +35,8 @@
List<String> args,
[String stdin = ""]) {
Future<String> getOutput(Stream<List<int>> stream) {
- return stream.transform(new StringDecoder())
- .reduce(new StringBuffer(), (buf, data) {
- buf.write(data);
- return buf;
- }).then((buf) => buf.toString());
+ return stream.transform(new StringDecoder()).toList()
+ .then((data) => data.join(""));
}
DebugLogger.info("Running: '\$ $executable ${args.join(' ')}'");
« no previous file with comments | « tools/test.dart ('k') | tools/testing/dart/browser_controller.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698