Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 18089005: Fix safari browser to use Future.value (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | tools/testing/dart/vendored_pkg/args/args.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 24520)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -60,7 +60,7 @@
// TODO(rnystrom): Copied from web_components. Remove from here when it gets
// added to dart:core. (See #6626.)
class FutureGroup {
- const _FINISHED = -1;
+ static const _FINISHED = -1;
int _pending = 0;
Completer<List> _completer = new Completer<List>();
final List<Future> futures = <Future>[];
@@ -907,7 +907,7 @@
*/
void enqueueBrowserTest(TestInformation info,
String testName,
- Object expectations,
+ expectations,
bool isWrappingRequired) {
// TODO(kustermann/ricow): This method should be refactored.
Map optionsFromFile = info.optionsFromFile;
@@ -999,7 +999,7 @@
// Variables for browser multi-tests.
List<String> subtestNames = info.optionsFromFile['subtestNames'];
- TestCase multitestParentTest;
+ BrowserTestCase multitestParentTest;
int subtestIndex = 0;
// Construct the command that executes the browser test
do {
« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | tools/testing/dart/vendored_pkg/args/args.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698