Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1707173002: Add browser tags to all of our tests. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -64 lines) Patch
M dart_test.yaml View 1 chunk +14 lines, -0 lines 2 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/chrome_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/browser/compact_reporter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/content_shell_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/browser/dartium_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/browser/expanded_reporter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/browser/firefox_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/browser/internet_explorer_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/browser/loader_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/browser/phantom_js_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/browser/runner_test.dart View 34 chunks +36 lines, -36 lines 0 comments Download
M test/runner/browser/safari_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/runner/pause_after_load_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M test/runner/pub_serve_test.dart View 9 chunks +9 lines, -9 lines 0 comments Download
M test/runner/signal_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/runner/tag_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runner/test_on_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
4 years, 10 months ago (2016-02-17 23:14:55 UTC) #1
kevmoo
lgtm
4 years, 10 months ago (2016-02-17 23:19:27 UTC) #2
nweiz
Committed patchset #1 (id:1) manually as 6aa123d0c96da71052ca4e01c9f431a881eb4928 (presubmit successful).
4 years, 10 months ago (2016-02-17 23:27:07 UTC) #4
kevmoo
A thought... https://codereview.chromium.org/1707173002/diff/1/dart_test.yaml File dart_test.yaml (right): https://codereview.chromium.org/1707173002/diff/1/dart_test.yaml#newcode8 dart_test.yaml:8: timeout: 2x 2x here is a bit ...
4 years, 10 months ago (2016-02-17 23:47:30 UTC) #5
nweiz
https://codereview.chromium.org/1707173002/diff/1/dart_test.yaml File dart_test.yaml (right): https://codereview.chromium.org/1707173002/diff/1/dart_test.yaml#newcode8 dart_test.yaml:8: timeout: 2x On 2016/02/17 23:47:30, kevmoo wrote: > 2x ...
4 years, 10 months ago (2016-02-18 00:02:58 UTC) #6
kevmoo
4 years, 10 months ago (2016-02-18 00:05:12 UTC) #7
Message was sent while issue was closed. 
On 2016/02/18 00:02:58, nweiz wrote:
> https://codereview.chromium.org/1707173002/diff/1/dart_test.yaml
> File dart_test.yaml (right):
> 
> https://codereview.chromium.org/1707173002/diff/1/dart_test.yaml#newcode8
> dart_test.yaml:8: timeout: 2x
> On 2016/02/17 23:47:30, kevmoo wrote:
> > 2x here is a bit redundant, no?
> 
> No, it's cumulative with the browser timeout. So dart2js tests end up having
4x
> the baseline timeout.

Might be worth a comment – if only for the curious to understand

Powered by Google App Engine
This is Rietveld 408576698