Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: dart_test.yaml

Issue 1707173002: Add browser tags to all of our tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pubspec.yaml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Terse traces hide frames from test itself, which is bad. 1 # Terse traces hide frames from test itself, which is bad.
2 verbose_trace: true 2 verbose_trace: true
3
4 tags:
5 browser: {timeout: 2x}
6 dart2js:
7 add_tags: [browser]
8 timeout: 2x
kevmoo 2016/02/17 23:47:30 2x here is a bit redundant, no?
nweiz 2016/02/18 00:02:58 No, it's cumulative with the browser timeout. So d
9
10 firefox: {add_tags: [dart2js]}
11 chrome: {add_tags: [dart2js]}
12 safari: {add_tags: [dart2js]}
13 ie: {add_tags: [dart2js]}
14 phantomjs: {add_tags: [dart2js]}
15 content-shell: {add_tags: [browser]}
16 dartium: {add_tags: [browser]}
OLDNEW
« no previous file with comments | « no previous file | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698