Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: test/runner/test_on_test.dart

Issue 1707173002: Add browser tags to all of our tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart_test.yaml ('K') | « test/runner/tag_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/test_on_test.dart
diff --git a/test/runner/test_on_test.dart b/test/runner/test_on_test.dart
index 8c34a102ea9d7e59c8b23bba42a9fde01fd4b9fb..01b321c0c76b6d8e4e50934fc6a68e5a568368d7 100644
--- a/test/runner/test_on_test.dart
+++ b/test/runner/test_on_test.dart
@@ -33,7 +33,7 @@ void main() {
var test = runTest(["--platform", "content-shell", "vm_test.dart"]);
test.stdout.expect(consumeThrough(contains("No tests ran.")));
test.shouldExit(0);
- });
+ }, tags: 'content-shell');
test("runs a test suite on a matching operating system", () {
_writeTestFile("os_test.dart", suiteTestOn: currentOS.name);
@@ -90,7 +90,7 @@ void main() {
["--platform", "content-shell", "browser_test.dart"]);
test.stdout.expect(consumeThrough(contains("All tests passed!")));
test.shouldExit(0);
- });
+ }, tags: 'content-shell');
test("doesn't run a VM group on a browser", () {
_writeTestFile("vm_test.dart", groupTestOn: "vm");
@@ -98,7 +98,7 @@ void main() {
var test = runTest(["--platform", "content-shell", "vm_test.dart"]);
test.stdout.expect(consumeThrough(contains("No tests ran.")));
test.shouldExit(0);
- });
+ }, tags: 'content-shell');
});
group("for test", () {
@@ -125,7 +125,7 @@ void main() {
["--platform", "content-shell", "browser_test.dart"]);
test.stdout.expect(consumeThrough(contains("All tests passed!")));
test.shouldExit(0);
- });
+ }, tags: 'content-shell');
test("doesn't run a VM test on a browser", () {
_writeTestFile("vm_test.dart", testTestOn: "vm");
@@ -133,7 +133,7 @@ void main() {
var test = runTest(["--platform", "content-shell", "vm_test.dart"]);
test.stdout.expect(consumeThrough(contains("No tests ran.")));
test.shouldExit(0);
- });
+ }, tags: 'content-shell');
});
group("with suite, group, and test selectors", () {
« dart_test.yaml ('K') | « test/runner/tag_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698