Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: test/runner/pub_serve_test.dart

Issue 1707173002: Add browser tags to all of our tests. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/runner/pub_serve_test.dart
diff --git a/test/runner/pub_serve_test.dart b/test/runner/pub_serve_test.dart
index 4d84f622df3b5d591ca5347422f9fe3bdb8aa47a..f6df2536edaebe63a39027193f699ae2aa3aa621 100644
--- a/test/runner/pub_serve_test.dart
+++ b/test/runner/pub_serve_test.dart
@@ -92,7 +92,7 @@ void main() {
test.stdout.expect(consumeThrough(contains('+1: All tests passed!')));
test.shouldExit(0);
pub.kill();
- });
+ }, tags: 'chrome');
test("runs those tests on content shell", () {
var pub = runPubServe();
@@ -100,7 +100,7 @@ void main() {
test.stdout.expect(consumeThrough(contains('+1: All tests passed!')));
test.shouldExit(0);
pub.kill();
- });
+ }, tags: 'content-shell');
test("gracefully handles pub serve running on the wrong directory for "
"VM tests", () {
@@ -135,7 +135,7 @@ void main() {
test.shouldExit(1);
pub.kill();
- });
+ }, tags: 'chrome');
test("when run on content shell", () {
d.dir("web").create();
@@ -151,7 +151,7 @@ void main() {
test.shouldExit(1);
pub.kill();
- });
+ }, tags: 'content-shell');
});
test("gracefully handles unconfigured transformers", () {
@@ -212,7 +212,7 @@ void main() {
test.stdout.expect(consumeThrough(contains('+1: All tests passed!')));
test.shouldExit(0);
pub.kill();
- });
+ }, tags: 'chrome');
test("on content shell", () {
var pub = runPubServe();
@@ -220,7 +220,7 @@ void main() {
test.stdout.expect(consumeThrough(contains('+1: All tests passed!')));
test.shouldExit(0);
pub.kill();
- });
+ }, tags: 'content-shell');
});
group("with a failing test", () {
@@ -246,7 +246,7 @@ void main() {
]));
test.shouldExit(1);
pub.kill();
- });
+ }, tags: 'chrome');
test("doesn't dartify stack traces for JS-compiled tests with --js-trace",
() {
@@ -265,7 +265,7 @@ void main() {
test.shouldExit(1);
pub.kill();
- });
+ }, tags: 'chrome');
});
test("gracefully handles pub serve not running for VM tests", () {
@@ -294,7 +294,7 @@ void main() {
'Make sure "pub serve" is running.'
]));
test.shouldExit(1);
- });
+ }, tags: 'chrome');
test("gracefully handles a test file not being in test/", () {
schedule(() {

Powered by Google App Engine
This is Rietveld 408576698