Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1691173002: Support tag configuration. (Closed)

Created:
4 years, 10 months ago by nweiz
Modified:
4 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -122 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M README.md View 2 chunks +43 lines, -0 lines 0 comments Download
M doc/package_config.md View 3 chunks +103 lines, -41 lines 0 comments Download
M lib/src/backend/metadata.dart View 1 2 6 chunks +80 lines, -13 lines 0 comments Download
M lib/src/frontend/tags.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/runner.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M lib/src/runner/configuration.dart View 7 chunks +56 lines, -24 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner/configuration/load.dart View 5 chunks +95 lines, -6 lines 0 comments Download
M lib/src/utils.dart View 1 chunk +26 lines, -6 lines 0 comments Download
M lib/test.dart View 2 chunks +12 lines, -6 lines 0 comments Download
M test/backend/metadata_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download
M test/runner/configuration/configuration_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download
A test/runner/configuration/tags_test.dart View 1 chunk +126 lines, -0 lines 0 comments Download
M test/runner/tag_test.dart View 6 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
nweiz
4 years, 10 months ago (2016-02-12 00:53:38 UTC) #1
kevmoo
I'm getting a lot of failures w/ this change. Running w/ json output to share ...
4 years, 10 months ago (2016-02-12 18:29:30 UTC) #2
kevmoo
LGTM - see one comment from previous post
4 years, 10 months ago (2016-02-16 22:52:42 UTC) #3
nweiz
Code review changes
4 years, 10 months ago (2016-02-16 23:36:08 UTC) #4
nweiz
https://codereview.chromium.org/1691173002/diff/20001/lib/src/backend/metadata.dart File lib/src/backend/metadata.dart (right): https://codereview.chromium.org/1691173002/diff/20001/lib/src/backend/metadata.dart#newcode174 lib/src/backend/metadata.dart:174: : new UnmodifiableSetView(tags.toSet()), On 2016/02/12 18:29:30, kevmoo wrote: > ...
4 years, 10 months ago (2016-02-16 23:36:31 UTC) #5
nweiz
4 years, 10 months ago (2016-02-16 23:37:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
3ea724eeff6a5c3c325a7720d66e42e2e1532ec9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698