Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: test/runner/configuration/configuration_test.dart

Issue 1691173002: Support tag configuration. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/backend/metadata_test.dart ('k') | test/runner/configuration/tags_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/configuration/configuration_test.dart
diff --git a/test/runner/configuration/configuration_test.dart b/test/runner/configuration/configuration_test.dart
index 1fa22b545aa4ad3f35db2d3cdabbb68ac0ebf094..5172624a5497bbb0488a10bb9636830815a17fb8 100644
--- a/test/runner/configuration/configuration_test.dart
+++ b/test/runner/configuration/configuration_test.dart
@@ -138,39 +138,39 @@ void main() {
group("for tags", () {
test("if neither is defined, preserves the default", () {
var merged = new Configuration().merge(new Configuration());
- expect(merged.tags, isEmpty);
+ expect(merged.includeTags, isEmpty);
expect(merged.excludeTags, isEmpty);
});
test("if only the old configuration's is defined, uses it", () {
var merged = new Configuration(
- tags: ["foo", "bar"],
+ includeTags: ["foo", "bar"],
excludeTags: ["baz", "bang"])
.merge(new Configuration());
- expect(merged.tags, unorderedEquals(["foo", "bar"]));
+ expect(merged.includeTags, unorderedEquals(["foo", "bar"]));
expect(merged.excludeTags, unorderedEquals(["baz", "bang"]));
});
test("if only the new configuration's is defined, uses it", () {
var merged = new Configuration().merge(new Configuration(
- tags: ["foo", "bar"],
+ includeTags: ["foo", "bar"],
excludeTags: ["baz", "bang"]));
- expect(merged.tags, unorderedEquals(["foo", "bar"]));
+ expect(merged.includeTags, unorderedEquals(["foo", "bar"]));
expect(merged.excludeTags, unorderedEquals(["baz", "bang"]));
});
test("if both are defined, unions them", () {
var older = new Configuration(
- tags: ["foo", "bar"],
+ includeTags: ["foo", "bar"],
excludeTags: ["baz", "bang"]);
var newer = new Configuration(
- tags: ["bar", "blip"],
+ includeTags: ["bar", "blip"],
excludeTags: ["bang", "qux"]);
var merged = older.merge(newer);
- expect(merged.tags, unorderedEquals(["foo", "bar", "blip"]));
+ expect(merged.includeTags, unorderedEquals(["foo", "bar", "blip"]));
expect(merged.excludeTags, unorderedEquals(["baz", "bang", "qux"]));
});
});
« no previous file with comments | « test/backend/metadata_test.dart ('k') | test/runner/configuration/tags_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698