Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: test/runner/tag_test.dart

Issue 1691173002: Support tag configuration. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/configuration/tags_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/tag_test.dart
diff --git a/test/runner/tag_test.dart b/test/runner/tag_test.dart
index 438ea4e8a7e4606053cbc5400f46b68827588072..294e4eb739e6908eecea7e9bf40b7eeb838ad2e2 100644
--- a/test/runner/tag_test.dart
+++ b/test/runner/tag_test.dart
@@ -178,8 +178,7 @@ void main() {
var test = runTest(["test.dart"]);
test.stdout.expect(consumeThrough(lines(
- 'Warning: Tags were used that weren\'t specified on the command '
- 'line.\n'
+ 'Warning: Tags were used that weren\'t specified in dart_test.yaml.\n'
' a was used in the test "foo"\n'
' b was used in the test "foo"')));
test.shouldExit(0);
@@ -197,8 +196,7 @@ void main() {
var test = runTest(["test.dart"]);
test.stdout.expect(consumeThrough(lines(
- 'Warning: A tag was used that wasn\'t specified on the command '
- 'line.\n'
+ 'Warning: A tag was used that wasn\'t specified in dart_test.yaml.\n'
' a was used in:\n'
' the test "foo"\n'
' the test "bar"')));
@@ -219,8 +217,7 @@ void main() {
var test = runTest(["test.dart"]);
test.stdout.expect(consumeThrough(lines(
- 'Warning: A tag was used that wasn\'t specified on the command '
- 'line.\n'
+ 'Warning: A tag was used that wasn\'t specified in dart_test.yaml.\n'
' a was used in the group "group"')));
test.shouldExit(0);
});
@@ -238,8 +235,7 @@ void main() {
var test = runTest(["test.dart"]);
test.stdout.expect(consumeThrough(lines(
- 'Warning: A tag was used that wasn\'t specified on the command '
- 'line.\n'
+ 'Warning: A tag was used that wasn\'t specified in dart_test.yaml.\n'
' a was used in the suite itself')));
test.shouldExit(0);
});
@@ -255,8 +251,7 @@ void main() {
var test = runTest(["-p", "vm,content-shell", "test.dart"]);
test.stdout.expect(consumeThrough(lines(
- 'Warning: A tag was used that wasn\'t specified on the command '
- 'line.\n'
+ 'Warning: A tag was used that wasn\'t specified in dart_test.yaml.\n'
' a was used in the test "foo"')));
test.stdout.expect(never(startsWith("Warning:")));
test.shouldExit(0);
@@ -324,8 +319,8 @@ void main() {
StreamMatcher tagWarnings(List<String> tags) => inOrder(() sync* {
yield consumeThrough(
"Warning: ${tags.length == 1 ? 'A tag was' : 'Tags were'} used that "
- "${tags.length == 1 ? "wasn't" : "weren't"} specified on the command "
- "line.");
+ "${tags.length == 1 ? "wasn't" : "weren't"} specified in "
+ "dart_test.yaml.");
for (var tag in tags) {
yield consumeWhile(isNot(contains(" was used in")));
« no previous file with comments | « test/runner/configuration/tags_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698