Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: test/backend/metadata_test.dart

Issue 1691173002: Support tag configuration. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/test.dart ('k') | test/runner/configuration/configuration_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/backend/metadata_test.dart
diff --git a/test/backend/metadata_test.dart b/test/backend/metadata_test.dart
index 40648381d8b9b6b97fa495ec00aa4b0ba278a958..adc8e78969801d272971596071c8692b60eba771 100644
--- a/test/backend/metadata_test.dart
+++ b/test/backend/metadata_test.dart
@@ -44,6 +44,63 @@ void main() {
});
});
+ group("constructor", () {
+ test("returns the normal metadata if there's no forTag", () {
+ var metadata = new Metadata(verboseTrace: true, tags: ['foo', 'bar']);
+ expect(metadata.verboseTrace, isTrue);
+ expect(metadata.tags, equals(['foo', 'bar']));
+ });
+
+ test("returns the normal metadata if there's no tags", () {
+ var metadata = new Metadata(verboseTrace: true,
+ forTag: {'foo': new Metadata(skip: true)});
+ expect(metadata.verboseTrace, isTrue);
+ expect(metadata.skip, isFalse);
+ expect(metadata.forTag, contains('foo'));
+ expect(metadata.forTag['foo'].skip, isTrue);
+ });
+
+ test("returns the normal metadata if forTag doesn't match tags", () {
+ var metadata = new Metadata(
+ verboseTrace: true,
+ tags: ['bar', 'baz'],
+ forTag: {'foo': new Metadata(skip: true)});
+
+ expect(metadata.verboseTrace, isTrue);
+ expect(metadata.skip, isFalse);
+ expect(metadata.tags, ['bar', 'baz']);
+ expect(metadata.forTag, contains('foo'));
+ expect(metadata.forTag['foo'].skip, isTrue);
+ });
+
+ test("resolves forTags that match tags", () {
+ var metadata = new Metadata(
+ verboseTrace: true,
+ tags: ['foo', 'bar', 'baz'],
+ forTag: {
+ 'foo': new Metadata(skip: true),
+ 'baz': new Metadata(timeout: Timeout.none),
+ 'qux': new Metadata(skipReason: "blah")
+ });
+
+ expect(metadata.verboseTrace, isTrue);
+ expect(metadata.skip, isTrue);
+ expect(metadata.skipReason, isNull);
+ expect(metadata.timeout, equals(Timeout.none));
+ expect(metadata.tags, equals(['foo', 'bar', 'baz']));
+ expect(metadata.forTag.keys, equals(['qux']));
+ });
+
+ test("base metadata takes precedence over forTags", () {
+ var metadata = new Metadata(
+ verboseTrace: true,
+ tags: ['foo'],
+ forTag: {'foo': new Metadata(verboseTrace: false)});
+
+ expect(metadata.verboseTrace, isTrue);
+ });
+ });
+
group("onPlatform", () {
test("parses a valid map", () {
var metadata = new Metadata.parse(onPlatform: {
« no previous file with comments | « lib/test.dart ('k') | test/runner/configuration/configuration_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698