Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 15431003: Cleanup of various DOM dart2js and dart_analyzer warnings (Closed)

Created:
7 years, 7 months ago by blois
Modified:
7 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup of various DOM dart2js and dart_analyzer warnings BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22976

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -54 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 11 chunks +25 lines, -19 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 9 chunks +13 lines, -13 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/dom/src/ImmutableListMixin.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/src/TemplateBindings.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/dart2js_Conversions.dart View 1 chunk +8 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +3 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 7 months ago (2013-05-21 20:40:28 UTC) #1
sra1
lgtm
7 years, 7 months ago (2013-05-22 01:14:50 UTC) #2
blois
7 years, 7 months ago (2013-05-22 01:23:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698