Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 15431003: Cleanup of various DOM dart2js and dart_analyzer warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of $LIBRARYNAME; 5 part of $LIBRARYNAME;
6 6
7 class _ChildrenElementList extends ListBase<Element> { 7 class _ChildrenElementList extends ListBase<Element> {
8 // Raw Element. 8 // Raw Element.
9 final Element _element; 9 final Element _element;
10 final HtmlCollection _childElements; 10 final HtmlCollection _childElements;
(...skipping 618 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 } else if (JS('bool', '!!#.mozMatchesSelector', this)) { 629 } else if (JS('bool', '!!#.mozMatchesSelector', this)) {
630 return JS('bool', '#.mozMatchesSelector(#)', this, selectors); 630 return JS('bool', '#.mozMatchesSelector(#)', this, selectors);
631 } else if (JS('bool', '!!#.msMatchesSelector', this)) { 631 } else if (JS('bool', '!!#.msMatchesSelector', this)) {
632 return JS('bool', '#.msMatchesSelector(#)', this, selectors); 632 return JS('bool', '#.msMatchesSelector(#)', this, selectors);
633 } 633 }
634 throw new UnsupportedError("Not supported on this platform"); 634 throw new UnsupportedError("Not supported on this platform");
635 } 635 }
636 $else 636 $else
637 $endif 637 $endif
638 638
639 @Creates('Null') 639 $if DART2JS
640 @Creates('Null') // Set from Dart code; does not instantiate a native type.
641 $endif
640 Map<String, StreamSubscription> _attributeBindings; 642 Map<String, StreamSubscription> _attributeBindings;
641 643
642 // TODO(jmesserly): I'm concerned about adding these to every element. 644 // TODO(jmesserly): I'm concerned about adding these to every element.
643 // Conceptually all of these belong on TemplateElement. They are here to 645 // Conceptually all of these belong on TemplateElement. They are here to
644 // support browsers that don't have <template> yet. 646 // support browsers that don't have <template> yet.
645 // However even in the polyfill they're restricted to certain tags 647 // However even in the polyfill they're restricted to certain tags
646 // (see [isTemplate]). So we can probably convert it to a (public) mixin, and 648 // (see [isTemplate]). So we can probably convert it to a (public) mixin, and
647 // only mix it in to the elements that need it. 649 // only mix it in to the elements that need it.
648 $if DART2JS 650 $if DART2JS
649 @Creates('Null') // Set from Dart code; does not instantiate a native type. 651 @Creates('Null') // Set from Dart code; does not instantiate a native type.
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
1034 const ScrollAlignment._internal(this._value); 1036 const ScrollAlignment._internal(this._value);
1035 toString() => 'ScrollAlignment.$_value'; 1037 toString() => 'ScrollAlignment.$_value';
1036 1038
1037 /// Attempt to align the element to the top of the scrollable area. 1039 /// Attempt to align the element to the top of the scrollable area.
1038 static const TOP = const ScrollAlignment._internal('TOP'); 1040 static const TOP = const ScrollAlignment._internal('TOP');
1039 /// Attempt to center the element in the scrollable area. 1041 /// Attempt to center the element in the scrollable area.
1040 static const CENTER = const ScrollAlignment._internal('CENTER'); 1042 static const CENTER = const ScrollAlignment._internal('CENTER');
1041 /// Attempt to align the element to the bottom of the scrollable area. 1043 /// Attempt to align the element to the bottom of the scrollable area.
1042 static const BOTTOM = const ScrollAlignment._internal('BOTTOM'); 1044 static const BOTTOM = const ScrollAlignment._internal('BOTTOM');
1043 } 1045 }
OLDNEW
« no previous file with comments | « tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate ('k') | tools/dom/templates/html/impl/impl_Node.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698