tools/dom/templates/html/impl/impl_Node.darttemplate - Issue 15431003: Cleanup of various DOM dart2js and dart_analyzer warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/templates/html/impl/impl_Node.darttemplate

Issue 15431003: Cleanup of various DOM dart2js and dart_analyzer warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/dom/templates/html/impl/impl_Element.darttemplate ('k') | tools/dom/templates/html/impl/impl_SVGElement.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/templates/html/impl/impl_Node.darttemplate

diff --git a/tools/dom/templates/html/impl/impl_Node.darttemplate b/tools/dom/templates/html/impl/impl_Node.darttemplate

index 04b03cd9542a1cb9129e09e4e72808bfa11fddfe..287151fb05929ae1a3f423108b80287914afe28f 100644

--- a/tools/dom/templates/html/impl/impl_Node.darttemplate

+++ b/tools/dom/templates/html/impl/impl_Node.darttemplate

@@ -57,11 +57,12 @@ $endif

void addAll(Iterable<Node> iterable) {

if (iterable is _ChildNodeListLazy) {

- if (!identical(iterable._this, _this)) {

+ _ChildNodeListLazy otherList = iterable;

+ if (!identical(otherList._this, _this)) {

// Optimized route for copying between nodes.

- for (var i = 0, len = iterable.length; i < len; ++i) {

+ for (var i = 0, len = otherList.length; i < len; ++i) {

// Should use $dom_firstChild, Bug 8886.

- _this.append(iterable[0]);

+ _this.append(otherList[0]);

}

return;