Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 15431003: Cleanup of various DOM dart2js and dart_analyzer warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 6c139d5bfbf930627f2060112467782ba98c11f2..bfb9eae26cf235b929376ea20b583ac33669b1a8 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -7975,7 +7975,6 @@ abstract class Element extends Node implements ElementTraversal {
}
- @Creates('Null')
Map<String, StreamSubscription> _attributeBindings;
// TODO(jmesserly): I'm concerned about adding these to every element.
@@ -16123,11 +16122,12 @@ class _ChildNodeListLazy extends ListBase<Node> {
void addAll(Iterable<Node> iterable) {
if (iterable is _ChildNodeListLazy) {
- if (!identical(iterable._this, _this)) {
+ _ChildNodeListLazy otherList = iterable;
+ if (!identical(otherList._this, _this)) {
// Optimized route for copying between nodes.
- for (var i = 0, len = iterable.length; i < len; ++i) {
+ for (var i = 0, len = otherList.length; i < len; ++i) {
// Should use $dom_firstChild, Bug 8886.
- _this.append(iterable[0]);
+ _this.append(otherList[0]);
}
}
return;
@@ -26243,16 +26243,16 @@ class _EventStreamSubscription<T extends Event> extends StreamSubscription<T> {
}
}
- bool get _paused => _pauseCount > 0;
+ bool get isPaused => _pauseCount > 0;
void resume() {
- if (_canceled || !_paused) return;
+ if (_canceled || !isPaused) return;
--_pauseCount;
_tryResume();
}
void _tryResume() {
- if (_onData != null && !_paused) {
+ if (_onData != null && !isPaused) {
_target.$dom_addEventListener(_eventType, _onData, _useCapture);
}
}
@@ -26376,7 +26376,7 @@ abstract class ImmutableListMixin<E> implements List<E> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void remove(Object object) {
+ bool remove(Object object) {
throw new UnsupportedError("Cannot remove from immutable List.");
}
@@ -26388,7 +26388,7 @@ abstract class ImmutableListMixin<E> implements List<E> {
throw new UnsupportedError("Cannot remove from immutable List.");
}
- void setRange(int start, int end, Iterable<E> iterable, [int skipCount]) {
+ void setRange(int start, int end, Iterable<E> iterable, [int skipCount = 0]) {
throw new UnsupportedError("Cannot setRange on immutable List.");
}
@@ -28460,7 +28460,7 @@ class _Bindings {
}
// http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html#dfn-template-contents-owner
- static Document _getTemplateContentsOwner(Document doc) {
+ static Document _getTemplateContentsOwner(HtmlDocument doc) {
if (doc.window == null) {
return doc;
}
@@ -28538,7 +28538,7 @@ class _Bindings {
// template.
// TODO(jmesserly): node is DocumentFragment or Element
var descendents = (node as dynamic).queryAll(_allTemplatesSelectors);
- if (node is Element && node.isTemplate) bootstrap(node);
+ if (node is Element && (node as Element).isTemplate) bootstrap(node);
descendents.forEach(bootstrap);
}
@@ -28692,7 +28692,7 @@ class _Bindings {
static void _removeChild(Node parent, Node child) {
child._templateInstance = null;
- if (child is Element && child.isTemplate) {
+ if (child is Element && (child as Element).isTemplate) {
// Make sure we stop observing when we remove an element.
var templateIterator = child._templateIterator;
if (templateIterator != null) {
@@ -28945,7 +28945,7 @@ class _WrappedList<E> extends ListBase<E> {
void add(E element) { _list.add(element); }
- void remove(Object element) { _list.remove(element); }
+ bool remove(Object element) => _list.remove(element);
void clear() { _list.clear(); }
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698