Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1530353002: Drop support for older Barback versions. (Closed)

Created:
5 years ago by nweiz
Modified:
5 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop support for older Barback versions. This also allows us to limit our tests to the latest barback, which simplifies the necessary infrastructure and speeds up the tests dramatically. Closes #1367 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/a1dd3484795b2bc221aaa8d007f3162251b3c08e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1724 lines, -2048 lines) Patch
D .gitmodules View 1 chunk +0 lines, -12 lines 0 comments Download
M .test_config View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/src/asset/dart/serialize.dart View 2 chunks +0 lines, -15 lines 0 comments Download
M lib/src/asset/dart/serialize/aggregate_transform.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M lib/src/asset/dart/transformer_isolate.dart View 3 chunks +2 lines, -13 lines 0 comments Download
M lib/src/barback.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/build/allows_arbitrary_modes_test.dart View 1 chunk +24 lines, -26 lines 0 comments Download
M test/build/defaults_to_release_mode_test.dart View 1 chunk +26 lines, -28 lines 0 comments Download
M test/build/outputs_error_to_json_test.dart View 1 chunk +29 lines, -31 lines 0 comments Download
M test/dart2js/compiles_generated_dart_file_test.dart View 1 chunk +18 lines, -20 lines 0 comments Download
M test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/dart2js/compiles_generated_file_from_dependency_test.dart View 1 chunk +27 lines, -29 lines 0 comments Download
M test/dart2js/compiles_imported_generated_file_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download
M test/dart2js/output_can_be_consumed_by_successive_phases.dart View 1 chunk +18 lines, -20 lines 0 comments Download
M test/global/run/runs_transformer_test.dart View 1 chunk +17 lines, -19 lines 0 comments Download
M test/run/displays_transformer_logs_test.dart View 1 chunk +30 lines, -32 lines 0 comments Download
M test/run/does_not_run_on_transformer_error_test.dart View 1 chunk +26 lines, -28 lines 0 comments Download
M test/run/doesnt_load_an_unnecessary_transformer_test.dart View 1 chunk +25 lines, -27 lines 0 comments Download
M test/run/mode_test.dart View 1 chunk +52 lines, -54 lines 0 comments Download
M test/run/resource_test.dart View 2 chunks +22 lines, -24 lines 0 comments Download
M test/run/runs_a_generated_script_test.dart View 1 chunk +18 lines, -20 lines 0 comments Download
M test/run/runs_transformer_in_entrypoint_test.dart View 1 chunk +17 lines, -19 lines 0 comments Download
M test/serve/allows_arbitrary_modes_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download
M test/serve/defaults_to_debug_mode_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download
M test/serve/does_not_crash_if_an_unused_dart_file_has_a_syntax_error_test.dart View 1 chunk +18 lines, -20 lines 0 comments Download
M test/serve/native_watch_replaced_file_test.dart View 1 chunk +36 lines, -38 lines 0 comments Download
M test/serve/supports_user_defined_declaring_transformers_test.dart View 1 chunk +28 lines, -30 lines 0 comments Download
M test/serve/supports_user_defined_lazy_transformers_test.dart View 1 chunk +22 lines, -24 lines 0 comments Download
M test/test_pub.dart View 2 chunks +1 line, -105 lines 0 comments Download
M test/transformer/a_transformer_rejects_its_config_test.dart View 1 chunk +18 lines, -20 lines 0 comments Download
M test/transformer/asset_not_found_exceptions_are_detectable_test.dart View 1 chunk +23 lines, -25 lines 0 comments Download
M test/transformer/can_log_messages_test.dart View 3 chunks +2 lines, -36 lines 0 comments Download
M test/transformer/can_use_consume_primary_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/transformer/can_use_has_input_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/transformer/can_use_read_input_as_string_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download
M test/transformer/can_use_read_input_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download
M test/transformer/configuration/configuration_defaults_to_empty_map_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/transformer/configuration/passes_configuration_to_a_transformer_test.dart View 1 chunk +22 lines, -24 lines 0 comments Download
M test/transformer/configuration/with_configuration_only_instantiates_configurable_transformers_test.dart View 1 chunk +24 lines, -26 lines 0 comments Download
M test/transformer/dart2js_transformer_before_another_transformer_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/transformer/does_not_run_a_transform_on_an_input_in_another_package_test.dart View 1 chunk +22 lines, -24 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_glob_test.dart View 1 chunk +26 lines, -28 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_list_test.dart View 1 chunk +29 lines, -31 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_prefix_test.dart View 1 chunk +30 lines, -32 lines 0 comments Download
M test/transformer/exclusion/exclude_asset_string_test.dart View 1 chunk +26 lines, -28 lines 0 comments Download
M test/transformer/exclusion/include_asset_glob_test.dart View 1 chunk +26 lines, -28 lines 0 comments Download
M test/transformer/exclusion/include_asset_list_test.dart View 1 chunk +29 lines, -31 lines 0 comments Download
M test/transformer/exclusion/include_asset_prefix_test.dart View 1 chunk +30 lines, -32 lines 0 comments Download
M test/transformer/exclusion/include_asset_string_test.dart View 1 chunk +26 lines, -28 lines 0 comments Download
M test/transformer/exclusion/includes_before_excludes_test.dart View 1 chunk +27 lines, -29 lines 0 comments Download
M test/transformer/exclusion/works_on_aggregate_transformer_test.dart View 1 chunk +26 lines, -28 lines 0 comments Download
M test/transformer/exclusion/works_on_dart2js_test.dart View 1 chunk +34 lines, -36 lines 0 comments Download
M test/transformer/exclusion/works_on_lazy_transformer_test.dart View 1 chunk +35 lines, -37 lines 0 comments Download
M test/transformer/exclusion/works_on_transformer_group_test.dart View 1 chunk +32 lines, -34 lines 0 comments Download
M test/transformer/fails_to_load_a_file_that_defines_no_transforms_test.dart View 1 chunk +16 lines, -18 lines 0 comments Download
M test/transformer/fails_to_load_a_non_existent_transform_test.dart View 1 chunk +12 lines, -14 lines 0 comments Download
M test/transformer/fails_to_load_a_pubspec_with_reserved_transformer_test.dart View 1 chunk +15 lines, -17 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_from_a_deps_dev_dependency_test.dart View 1 chunk +29 lines, -31 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_from_a_non_dependency_test.dart View 1 chunk +11 lines, -13 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_with_a_syntax_error_test.dart View 1 chunk +15 lines, -17 lines 0 comments Download
M test/transformer/fails_to_load_a_transform_with_an_import_error_test.dart View 1 chunk +16 lines, -18 lines 0 comments Download
M test/transformer/fails_to_load_an_unconfigurable_transformer_when_config_is_passed_test.dart View 1 chunk +17 lines, -19 lines 0 comments Download
M test/transformer/loads_a_declaring_aggregate_transformer_test.dart View 1 chunk +21 lines, -23 lines 0 comments Download
M test/transformer/loads_a_diamond_transformer_dependency_graph_test.dart View 1 chunk +61 lines, -63 lines 0 comments Download
M test/transformer/loads_a_lazy_aggregate_transformer_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/transformer/loads_a_transformer_defined_in_an_exported_library_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download
M test/transformer/loads_an_aggregate_transformer_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/transformer/loads_different_configurations_from_the_same_isolate_test.dart View 1 chunk +65 lines, -67 lines 0 comments Download
M test/transformer/multiple_transformers_reject_their_config_test.dart View 1 chunk +27 lines, -29 lines 0 comments Download
M test/transformer/prefers_transformer_to_library_name_test.dart View 1 chunk +21 lines, -23 lines 0 comments Download
M test/transformer/prints_a_transform_error_in_apply_test.dart View 1 chunk +21 lines, -23 lines 0 comments Download
M test/transformer/prints_a_transform_interface_error_test.dart View 1 chunk +22 lines, -24 lines 0 comments Download
M test/transformer/runs_a_local_transform_on_the_application_package_test.dart View 1 chunk +17 lines, -19 lines 0 comments Download
M test/transformer/runs_a_third_party_transform_on_the_application_package_test.dart View 1 chunk +21 lines, -23 lines 0 comments Download
M test/transformer/runs_a_third_party_transformer_on_a_local_transformer_test.dart View 1 chunk +25 lines, -27 lines 0 comments Download
M test/transformer/runs_a_transformer_group_test.dart View 1 chunk +20 lines, -22 lines 0 comments Download
M test/transformer/runs_a_transformer_on_a_dependency_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download
M test/transformer/runs_one_third_party_transformer_on_another_test.dart View 1 chunk +36 lines, -38 lines 0 comments Download
M test/transformer/supports_a_transformer_that_doesnt_return_futures_test.dart View 1 chunk +19 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nweiz
I'm planning to land this eagerly, since it's becoming pretty clear that the pain of ...
5 years ago (2015-12-16 21:29:15 UTC) #2
Bob Nystrom
LGTM. The tests must run much faster now! Before you land this, I'd like you ...
5 years ago (2015-12-16 23:39:10 UTC) #3
nweiz
On 2015/12/16 23:39:10, Bob Nystrom wrote: > LGTM. The tests must run much faster now! ...
5 years ago (2015-12-17 22:11:33 UTC) #5
nweiz
5 years ago (2015-12-17 23:20:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a1dd3484795b2bc221aaa8d007f3162251b3c08e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698