Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: lib/src/asset/dart/transformer_isolate.dart

Issue 1530353002: Drop support for older Barback versions. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/asset/dart/serialize/aggregate_transform.dart ('k') | lib/src/barback.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/asset/dart/transformer_isolate.dart
diff --git a/lib/src/asset/dart/transformer_isolate.dart b/lib/src/asset/dart/transformer_isolate.dart
index 50bb97baac869e1a1ca8666246a6d312158efbed..06f78fcd802c93cf6555407a92a0ece41eff4e36 100644
--- a/lib/src/asset/dart/transformer_isolate.dart
+++ b/lib/src/asset/dart/transformer_isolate.dart
@@ -39,7 +39,7 @@ void loadTransformers(SendPort replyTo) {
/// in it, instantiates them with [configuration] and [mode], and returns them.
List _initialize(String uri, Map configuration, BarbackMode mode) {
var transformerClass = reflectClass(Transformer);
- var aggregateClass = _aggregateTransformerClass;
+ var aggregateClass = reflectClass(AggregateTransformer);
var groupClass = reflectClass(TransformerGroup);
var seen = new Set();
@@ -64,8 +64,7 @@ List _initialize(String uri, Map configuration, BarbackMode mode) {
if (classMirror.isAbstract) return null;
if (!classMirror.isSubtypeOf(transformerClass) &&
!classMirror.isSubtypeOf(groupClass) &&
- (aggregateClass == null ||
- !classMirror.isSubtypeOf(aggregateClass))) {
+ !classMirror.isSubtypeOf(aggregateClass)) {
return null;
}
@@ -100,13 +99,3 @@ MethodMirror _getConstructor(ClassMirror classMirror, String constructor) {
if (candidate is MethodMirror && candidate.isConstructor) return candidate;
return null;
}
-
-// Older barbacks don't support [AggregateTransformer], and calling
-// [reflectClass] on an undefined class will throw an error, so we just define a
-// null getter for them.
-//# if barback >=0.14.1
-ClassMirror get _aggregateTransformerClass =>
- reflectClass(AggregateTransformer);
-//# else
-//> ClassMirror get _aggregateTransformerClass => null;
-//# end
« no previous file with comments | « lib/src/asset/dart/serialize/aggregate_transform.dart ('k') | lib/src/barback.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698