Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: test/run/doesnt_load_an_unnecessary_transformer_test.dart

Issue 1530353002: Drop support for older Barback versions. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/run/does_not_run_on_transformer_error_test.dart ('k') | test/run/mode_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import '../descriptor.dart' as d; 5 import '../descriptor.dart' as d;
6 import '../test_pub.dart'; 6 import '../test_pub.dart';
7 import '../serve/utils.dart'; 7 import '../serve/utils.dart';
8 8
9 const TRANSFORMER = """ 9 const TRANSFORMER = """
10 import 'dart:async'; 10 import 'dart:async';
11 11
12 import 'package:barback/barback.dart'; 12 import 'package:barback/barback.dart';
13 13
14 class BrokenTransformer extends Transformer { 14 class BrokenTransformer extends Transformer {
15 RewriteTransformer.asPlugin() { 15 RewriteTransformer.asPlugin() {
16 throw 'This transformer is broken!'; 16 throw 'This transformer is broken!';
17 } 17 }
18 18
19 String get allowedExtensions => '.txt'; 19 String get allowedExtensions => '.txt';
20 20
21 void apply(Transform transform) {} 21 void apply(Transform transform) {}
22 } 22 }
23 """; 23 """;
24 24
25 main() { 25 main() {
26 withBarbackVersions("any", () { 26 integration("doesn't load an unnecessary transformer", () {
27 integration("doesn't load an unnecessary transformer", () { 27 d.dir(appPath, [
28 d.dir(appPath, [ 28 d.pubspec({
29 d.pubspec({ 29 "name": "myapp",
30 "name": "myapp", 30 "transformers": [
31 "transformers": [ 31 {"myapp/src/transformer": {r"$include": "lib/myapp.dart"}}
32 {"myapp/src/transformer": {r"$include": "lib/myapp.dart"}} 32 ]
33 ] 33 }),
34 }), 34 d.dir("lib", [
35 d.dir("lib", [ 35 d.file("myapp.dart", ""),
36 d.file("myapp.dart", ""), 36 d.dir("src", [d.file("transformer.dart", TRANSFORMER)])
37 d.dir("src", [d.file("transformer.dart", TRANSFORMER)]) 37 ]),
38 ]), 38 d.dir("bin", [
39 d.dir("bin", [ 39 d.file("hi.dart", "void main() => print('Hello!');")
40 d.file("hi.dart", "void main() => print('Hello!');") 40 ])
41 ]) 41 ]).create();
42 ]).create();
43 42
44 createLockFile('myapp', pkg: ['barback']); 43 createLockFile('myapp', pkg: ['barback']);
45 44
46 // This shouldn't load the transformer, since it doesn't transform 45 // This shouldn't load the transformer, since it doesn't transform
47 // anything that the entrypoint imports. If it did load the transformer, 46 // anything that the entrypoint imports. If it did load the transformer,
48 // we'd know since it would throw an exception. 47 // we'd know since it would throw an exception.
49 var pub = pubRun(args: ["bin/hi"]); 48 var pub = pubRun(args: ["bin/hi"]);
50 pub.stdout.expect("Hello!"); 49 pub.stdout.expect("Hello!");
51 pub.shouldExit(); 50 pub.shouldExit();
52 });
53 }); 51 });
54 } 52 }
OLDNEW
« no previous file with comments | « test/run/does_not_run_on_transformer_error_test.dart ('k') | test/run/mode_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698