Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1838)

Unified Diff: test/transformer/can_log_messages_test.dart

Issue 1530353002: Drop support for older Barback versions. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/transformer/can_log_messages_test.dart
diff --git a/test/transformer/can_log_messages_test.dart b/test/transformer/can_log_messages_test.dart
index 3705c5616a5875bcf62628727bd81a2eb4ad6402..2f0a52bdc98cf3a31a7099795318966c72d8790c 100644
--- a/test/transformer/can_log_messages_test.dart
+++ b/test/transformer/can_log_messages_test.dart
@@ -11,34 +11,7 @@ import 'package:scheduled_test/scheduled_stream.dart';
import '../descriptor.dart' as d;
import '../test_pub.dart';
-const SOURCE_MAPS_TRANSFORMER = """
-import 'dart:async';
-
-import 'package:barback/barback.dart';
-import 'package:source_maps/source_maps.dart';
-
-class RewriteTransformer extends Transformer {
- RewriteTransformer.asPlugin();
-
- String get allowedExtensions => '.txt';
-
- Future apply(Transform transform) {
- transform.logger.info('info!');
- transform.logger.warning('Warning!',
- asset: transform.primaryInput.id.changeExtension('.foo'));
- var sourceFile = new SourceFile.text(
- 'http://fake.com/not_real.dart',
- 'not a real\\ndart file');
- transform.logger.error('ERROR!', span: new FileSpan(sourceFile, 11));
- return transform.primaryInput.readAsString().then((contents) {
- var id = transform.primaryInput.id.changeExtension(".out");
- transform.addOutput(new Asset.fromString(id, "\$contents.out"));
- });
- }
-}
-""";
-
-const SOURCE_SPAN_TRANSFORMER = """
+const TRANSFORMER = """
import 'dart:async';
import 'package:barback/barback.dart';
@@ -65,13 +38,6 @@ class RewriteTransformer extends Transformer {
""";
main() {
- // This intentionally tests barback 0.14.2 with both transformers, since it
- // supports both types of span.
- withBarbackVersions("<0.15.0", () => runTest(SOURCE_MAPS_TRANSFORMER));
- withBarbackVersions(">=0.14.2", () => runTest(SOURCE_SPAN_TRANSFORMER));
-}
-
-void runTest(String transformerText) {
integration("can log messages", () {
d.dir(appPath, [
d.pubspec({
@@ -79,7 +45,7 @@ void runTest(String transformerText) {
"transformers": ["myapp/src/transformer"]
}),
d.dir("lib", [d.dir("src", [
- d.file("transformer.dart", transformerText)
+ d.file("transformer.dart", TRANSFORMER)
])]),
d.dir("web", [
d.file("foo.txt", "foo")

Powered by Google App Engine
This is Rietveld 408576698