Fixes for integer division on ARM hardware so that assembler tests pass.

Fixes for integer division on ARM hardware so that assembler tests pass.
Now, all VM tests that pass on SIMARM, pass on ARM.

Also, more assertions in the ARM disassembler and simulator to
make sure that condition codes aren't used with bkpt.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22471

[zra, 2013-05-07 16:33:03]

CPUInfoContainsString comes from v8. They detect features on arm first by
looking at compiler defines, and then by looking at /proc/cpuinfo. The only way
to detect the presence of the integer division instructions is to go to
/proc/cpuinfo, though. Hopefully it's okay to borrow this bit of code.

[regis, 2013-05-07 17:14:35]

LGTM

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm.c...
runtime/vm/assembler_arm.cc:11: #endif
Shoudn't it be
 #if !defined(USING_SIMULATOR) && !defined(__linux__)
otherwise, SIMARM will fail on Windows. I am not 100% sure we support it,
though, but we should.
In any case, you check /proc/cpuinfo only if !defined(USING_SIMULATOR).

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm.c...
runtime/vm/assembler_arm.cc:140: kStrExRtShift = 0,
Unrelated to your change, but these ldrex/strex register field encodings should
be moved to constants_arm.h where other shift counts are declared.

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm_t...
File runtime/vm/assembler_arm_test.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm_t...
runtime/vm/assembler_arm_test.cc:1392: __ mrc(R0, 15, 0, 0, 2, 0);
Could you add a comment here explaining what bits of register CP15 you are
checking?

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/disassembler_ar...
File runtime/vm/disassembler_arm.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/disassembler_ar...
runtime/vm/disassembler_arm.cc:605: Format(instr, "bkpt'cond #'imm12_4");
Remove 'cond.

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/simulator_arm.c...
runtime/vm/simulator_arm.cc:1486: // Format(instr, "bkpt'cond #'imm12_4");
Remove 'cond.

[zra, 2013-05-07 17:50:18]

Thanks!

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm.c...
runtime/vm/assembler_arm.cc:11: #endif
On 2013/05/07 17:14:35, regis wrote:
> Shoudn't it be
>  #if !defined(USING_SIMULATOR) && !defined(__linux__)
> otherwise, SIMARM will fail on Windows. I am not 100% sure we support it,
> though, but we should.
> In any case, you check /proc/cpuinfo only if !defined(USING_SIMULATOR).

Done.

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm.c...
runtime/vm/assembler_arm.cc:140: kStrExRtShift = 0,
On 2013/05/07 17:14:35, regis wrote:
> Unrelated to your change, but these ldrex/strex register field encodings
should
> be moved to constants_arm.h where other shift counts are declared.

Done.

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm_t...
File runtime/vm/assembler_arm_test.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/assembler_arm_t...
runtime/vm/assembler_arm_test.cc:1392: __ mrc(R0, 15, 0, 0, 2, 0);
On 2013/05/07 17:14:35, regis wrote:
> Could you add a comment here explaining what bits of register CP15 you are
> checking?

Done.

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/disassembler_ar...
File runtime/vm/disassembler_arm.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/disassembler_ar...
runtime/vm/disassembler_arm.cc:605: Format(instr, "bkpt'cond #'imm12_4");
On 2013/05/07 17:14:35, regis wrote:
> Remove 'cond.

Done.

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/simulator_arm.cc
File runtime/vm/simulator_arm.cc (right):

https://codereview.chromium.org/14784011/diff/6001/runtime/vm/simulator_arm.c...
runtime/vm/simulator_arm.cc:1486: // Format(instr, "bkpt'cond #'imm12_4");
On 2013/05/07 17:14:35, regis wrote:
> Remove 'cond.

Done.

[zra, 2013-05-07 18:21:24]

Committed patchset #3 manually as r22471 (presubmit successful).