Post-meetup feature extravaganza.

Post-meetup feature extravaganza.

Remodel the top-level isolate summary page.

Add variables to stack frames in the stack trace.

Stop putting small integers and bools in the object id ring.

Rework how we pass down null references (and null-like references like
uninitialized values).

Collect all isolate timers by default.

Change the lifetime of IsolateSpawnState so that we can refer to it
later to know how an isolate started up.  Stop pretending that
IsolateSpawnState is a void*.  Clean up vestigial IsolateStartData.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32128

[Cutch, 2014-01-28 19:32:50]

LGTM with suggestions

https://codereview.chromium.org/145323002/diff/220001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/observatory/isolate.dart (right):

https://codereview.chromium.org/145323002/diff/220001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/observatory/isolate.dart:72: if
(map['heap'] != null) {
Can we assert on these being present in the response? This is a larger question
on how rigid we want to be on messages from the service.

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc#n...
runtime/vm/service.cc:610: static_cast<intptr_t>(isolate->main_port()));
Does it make sense to move most of this into Isolate::PrintToJSONStream ?

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc#n...
runtime/vm/service.cc:630: StackFrame* top_frame = iterator.NextFrame();
Similiarly StackFrame::PrintToJSONStream?

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc#n...
runtime/vm/service.cc:959: 
Remove extra blank line.

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc#n...
runtime/vm/service.cc:977: 
Remove extra blank line.

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/timer.h
File runtime/vm/timer.h (right):

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/timer.h#newc...
runtime/vm/timer.h:21: report_(report), enabled_(true), running_(false),
message_(message) {}
Enabled is always true and has no setter, so why keep the field?

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/timer.h#newc...
runtime/vm/timer.h:178: TimerScope vm_internal_timer_(true,                     
                    \
Perhaps we to respect FLAG_enable_vm_service ?

[turnidge, 2014-01-28 23:18:55]

https://codereview.chromium.org/145323002/diff/220001/runtime/bin/vmservice/c...
File runtime/bin/vmservice/client/lib/src/observatory/isolate.dart (right):

https://codereview.chromium.org/145323002/diff/220001/runtime/bin/vmservice/c...
runtime/bin/vmservice/client/lib/src/observatory/isolate.dart:72: if
(map['heap'] != null) {
On 2014/01/28 19:32:51, Cutch wrote:
> Can we assert on these being present in the response? This is a larger
question
> on how rigid we want to be on messages from the service.

I changed the code to detect the malformed response and log an error.  I wasn't
sure about using assert's for this.

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc#n...
runtime/vm/service.cc:610: static_cast<intptr_t>(isolate->main_port()));
On 2014/01/28 19:32:51, Cutch wrote:
> Does it make sense to move most of this into Isolate::PrintToJSONStream ?

Yes, done.

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/service.cc#n...
runtime/vm/service.cc:630: StackFrame* top_frame = iterator.NextFrame();
On 2014/01/28 19:32:51, Cutch wrote:
> Similiarly StackFrame::PrintToJSONStream?

I've updated all of the stack display code to use the Debugger's stack frame
rather than the usual system one and I've moved some of the print functionality
there.

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/timer.h
File runtime/vm/timer.h (right):

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/timer.h#newc...
runtime/vm/timer.h:21: report_(report), enabled_(true), running_(false),
message_(message) {}
On 2014/01/28 19:32:51, Cutch wrote:
> Enabled is always true and has no setter, so why keep the field?

Removed.

https://codereview.chromium.org/145323002/diff/220001/runtime/vm/timer.h#newc...
runtime/vm/timer.h:178: TimerScope vm_internal_timer_(true,                     
                    \
On 2014/01/28 19:32:51, Cutch wrote:
> Perhaps we to respect FLAG_enable_vm_service ?

That flag is in bin/main.cc -- not available.

[turnidge, 2014-01-29 18:40:38]

Committed patchset #16 manually as r32128 (presubmit successful).