Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: tests/standalone/vmservice/isolate_class_test.dart

Issue 145323002: Post-meetup feature extravaganza. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/standalone/vmservice/isolate_class_test.dart
===================================================================
--- tests/standalone/vmservice/isolate_class_test.dart (revision 32126)
+++ tests/standalone/vmservice/isolate_class_test.dart (working copy)
@@ -35,15 +35,15 @@
}
}
-class RootLibraryTest extends VmServiceRequestHelper {
- RootLibraryTest(port, id) :
- super('http://127.0.0.1:$port/$id/library');
+class IsolateSummaryTest extends VmServiceRequestHelper {
+ IsolateSummaryTest(port, id) :
+ super('http://127.0.0.1:$port/$id/');
String _libId;
onRequestCompleted(Map reply) {
- Expect.equals('Library', reply['type']);
- Expect.equals('isolate_stacktrace_command_script', reply['name']);
- _libId = reply['id'];
+ Expect.equals('Isolate', reply['type']);
+ Expect.equals('isolate_stacktrace_command_script', reply['rootLib']['name']);
+ _libId = reply['rootLib']['id'];
}
}
@@ -54,8 +54,8 @@
onRequestCompleted(Map reply) {
IsolateListTester tester = new IsolateListTester(reply);
tester.checkIsolateCount(2);
- tester.checkIsolateNameContains('isolate_stacktrace_command_script.dart');
- _isolateId = tester.checkIsolateNameContains('myIsolateName');
+ // TODO(turnidge): Fragile. Relies on isolate order in response.
+ _isolateId = tester.getIsolateId(1);
}
}
@@ -64,11 +64,11 @@
process.launch().then((port) {
var test = new IsolateListTest(port);
test.makeRequest().then((_) {
- var rootLibraryTest =
- new RootLibraryTest(port, test._isolateId);
- rootLibraryTest.makeRequest().then((_) {
+ var isolateSummaryTest =
+ new IsolateSummaryTest(port, test._isolateId);
+ isolateSummaryTest.makeRequest().then((_) {
var libraryTest = new LibraryTest(port, test._isolateId,
- rootLibraryTest._libId);
+ isolateSummaryTest._libId);
libraryTest.makeRequest().then((_) {
var classTest = new ClassTest(port, test._isolateId,
libraryTest._classId);
« no previous file with comments | « tests/standalone/vmservice/isolate_class_field_test.dart ('k') | tests/standalone/vmservice/isolate_code_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698