Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.html

Issue 145323002: Post-meetup feature extravaganza. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.html
===================================================================
--- runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.html (revision 32126)
+++ runtime/bin/vmservice/client/lib/src/observatory_elements/stack_trace.html (working copy)
@@ -1,29 +1,24 @@
<head>
- <link rel="import" href="function_ref.html">
<link rel="import" href="observatory_element.html">
- <link rel="import" href="script_ref.html">
+ <link rel="import" href="stack_frame.html">
</head>
<polymer-element name="stack-trace" extends="observatory-element">
<template>
- <div class="alert alert-info">Stack Trace</div>
- <table class="table table-hover">
- <thead>
- <tr>
- <th>Depth</th>
- <th>Function</th>
- <th>Script</th>
- <th>Line</th>
- </tr>
- </thead>
- <tbody>
- <tr template repeat="{{ frame in trace['members'] }}">
- <td></td>
- <td><function-ref app="{{ app }}" ref="{{ frame['function'] }}"></function-ref></td>
- <td><script-ref app="{{ app }}" ref="{{ frame['script'] }}"></script-ref></td>
- <td>{{ frame['line'] }}</td>
- </tr>
- </tbody>
- </table>
+ <template if="{{ trace['members'].isEmpty }}">
+ <div class="col-md-1"></div>
+ <div class="col-md-11">
+ <em>No stack</em>
+ </div>
+ </template>
+ <template if="{{ trace['members'].isNotEmpty }}">
+ <ul class="list-group">
+ <template repeat="{{ frame in trace['members'] }}">
+ <li class="list-group-item">
+ <stack-frame app="{{ app }}" frame="{{ frame }}"></stack-frame>
+ </li>
+ </template>
+ </ul>
+ </template>
</template>
<script type="application/dart" src="stack_trace.dart"></script>
-</polymer-element>
+</polymer-element>
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/stack_frame.html ('k') | runtime/include/dart_debugger_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698