runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart - Issue 145323002: Post-meetup feature extravaganza.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart

Issue 145323002: Post-meetup feature extravaganza. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory/isolate.dart ('k') | runtime/bin/vmservice/client/lib/src/observatory_elements/instance_ref.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart

===================================================================

--- runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart (revision 32126)

+++ runtime/bin/vmservice/client/lib/src/observatory/isolate_manager.dart (working copy)

@@ -27,7 +27,7 @@

Isolate getIsolate(String id) {

Isolate isolate = isolates[id];

if (isolate == null) {

- isolate = new Isolate(id, id);

+ isolate = new Isolate.fromId(id);

isolates[id] = isolate;

return isolate;

}

@@ -43,19 +43,18 @@

}

});

// Remove them.

- deadIsolates.forEach((k) {

- isolates.remove(k);

+ deadIsolates.forEach((id) {

+ isolates.remove(id);

});

// Add new isolates.

- members.forEach((k) {

- var id = k['id'];

- var name = k['name'];

- if (isolates[id] == null) {

- var isolate = new Isolate(id, name);

+ members.forEach((map) {

+ var id = map['id'];

+ var isolate = isolates[id];

+ if (isolate == null) {

+ isolate = new Isolate.fromMap(map);

isolates[id] = isolate;

- } else {

- isolates[id].name = name;

}

+ isolate.refresh();

});

}