Issue 14284020: Adds support for debugger API on MIPS.

Issue 14284020: Adds support for debugger API on MIPS. (Closed)

Created:
7 years, 8 months ago by zra

Modified:
7 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds support for debugger API on MIPS. Enable debugger api tests on MIPS. Enable isolate tests on MIPS. Enable code descriptors tests on MIPS. Enable snapshot tests on MIPS. Enable heap tests on MIPS. Committed: https://code.google.com/p/dart/source/detail?r=22042

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -77 lines)			Patch
M	runtime/vm/assembler_mips.cc	View	1	4 chunks	+11 lines, -6 lines	0 comments	Download
M	runtime/vm/code_descriptors_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/code_patcher_mips.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/constants_mips.h	View	1	3 chunks	+36 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/debugger_mips.cc	View	1	1 chunk	+62 lines, -6 lines	0 comments	Download
M	runtime/vm/heap_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/instructions_mips.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	3 chunks	+51 lines, -19 lines	0 comments	Download
M	runtime/vm/isolate_test.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/object_store.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/stack_frame_mips.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View		3 chunks	+91 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/14284020/diff/2002/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc (right): https://codereview.chromium.org/14284020/diff/2002/runtime/vm/intermediate_language_mips.cc#newcode103 runtime/vm/intermediate_language_mips.cc:103: __ Ret(); I would leave a comment here ...

7 years, 8 months ago (2013-04-25 17:27:14 UTC) #2

zra

Thanks! https://codereview.chromium.org/14284020/diff/2002/runtime/vm/intermediate_language_mips.cc File runtime/vm/intermediate_language_mips.cc (right): https://codereview.chromium.org/14284020/diff/2002/runtime/vm/intermediate_language_mips.cc#newcode103 runtime/vm/intermediate_language_mips.cc:103: __ Ret(); On 2013/04/25 17:27:15, regis wrote: > ...

7 years, 8 months ago (2013-04-25 17:47:35 UTC) #3

zra

7 years, 8 months ago (2013-04-25 18:03:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r22042 (presubmit successful).

Expand Messages | Collapse Messages