Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove.

Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21338

[floitsch, 2013-04-11 15:17:50]

LGTM.

https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.googl...
File editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart
(right):

https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:260:
class ListWrapper<E> extends Iterable<E> implements List<E> {
I'm guessing that the ListWrapper extends Collection to get its functionality.
I would replace it with ListBase<E>.

https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:283: void
addLast(E value) {
Can be removed.

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/generated/element.dart (right):

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/element.dart:1280:
Iterable<InterfaceType> list = new Set<InterfaceType>();
Set and the name should be replaced from 'list' to 'set' :)

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/element.dart:1544: void
collectAllSupertypes(Iterable<InterfaceType> list) {
No. There is an 'add' call in line 1548.
Make it 'var'.

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/generated/java_core.dart (right):

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/java_core.dart:260: class
ListWrapper<E> extends Iterable<E> implements List<E> {
extends ListBase<E>.
This way it gets the functionality.

https://codereview.chromium.org/14173003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/14173003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:737: final
Map<String, Iterable<ClassElement>> specializedGetInterceptors;
I think this should be a Set.

https://codereview.chromium.org/14173003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:771: new
Map<String, Iterable<ClassElement>>(),
Set

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-compiler.status
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-compiler.stat...
tests/co19/co19-compiler.status:224: # issue xxx - using removed deprecated
methods.
Don't forget to file an issue.
Put the issue number next to each test then (see above).

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-dart2js.statu...
tests/co19/co19-dart2js.status:370: # issue xxx - using removed deprecated
methods.
ditto.

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-runtime.statu...
tests/co19/co19-runtime.status:8: # issue xxx - using removed deprecated
methods.
ditto.

[nweiz, 2013-04-11 20:36:19]

The pub and pkg changes lgtm, mod a few changes.

Thanks for CCing me on this.

https://codereview.chromium.org/14173003/diff/1/pkg/args/lib/args.dart
File pkg/args/lib/args.dart (right):

https://codereview.chromium.org/14173003/diff/1/pkg/args/lib/args.dart#newcod...
pkg/args/lib/args.dart:421: Iterable<String> get options =>
_options.keys.toList(growable: false);
If you're returning this as an Iterable, you can just return _options.keys.

https://codereview.chromium.org/14173003/diff/1/utils/pub/utils.dart
File utils/pub/utils.dart (right):

https://codereview.chromium.org/14173003/diff/1/utils/pub/utils.dart#newcode336
utils/pub/utils.dart:336: /// Takes a simple data structure (composed of [Map]s,
[List]s, scalar objects,
"[List]s" -> "[Iterable]s"

https://codereview.chromium.org/14173003/diff/1/utils/pub/utils.dart#newcode342
utils/pub/utils.dart:342: if (object is List || object is Set) {
I think this should be "object is Iterable".

[Anders Johnsen, 2013-04-12 09:31:14]

Thank you, both, for the comments. Landing.

https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.googl...
File editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart
(right):

https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:260:
class ListWrapper<E> extends Iterable<E> implements List<E> {
On 2013/04/11 15:17:50, floitsch wrote:
> I'm guessing that the ListWrapper extends Collection to get its functionality.
> I would replace it with ListBase<E>.

Done.

https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:283: void
addLast(E value) {
On 2013/04/11 15:17:50, floitsch wrote:
> Can be removed.

Done.

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/generated/element.dart (right):

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/element.dart:1280:
Iterable<InterfaceType> list = new Set<InterfaceType>();
On 2013/04/11 15:17:50, floitsch wrote:
> Set and the name should be replaced from 'list' to 'set' :)

Done.

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/element.dart:1544: void
collectAllSupertypes(Iterable<InterfaceType> list) {
On 2013/04/11 15:17:50, floitsch wrote:
> No. There is an 'add' call in line 1548.
> Make it 'var'.

Done.

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/generated/java_core.dart (right):

https://codereview.chromium.org/14173003/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/generated/java_core.dart:260: class
ListWrapper<E> extends Iterable<E> implements List<E> {
On 2013/04/11 15:17:50, floitsch wrote:
> extends ListBase<E>.
> This way it gets the functionality.

Done.

https://codereview.chromium.org/14173003/diff/1/pkg/args/lib/args.dart
File pkg/args/lib/args.dart (right):

https://codereview.chromium.org/14173003/diff/1/pkg/args/lib/args.dart#newcod...
pkg/args/lib/args.dart:421: Iterable<String> get options =>
_options.keys.toList(growable: false);
On 2013/04/11 20:36:19, nweiz wrote:
> If you're returning this as an Iterable, you can just return _options.keys.

Done.

https://codereview.chromium.org/14173003/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right):

https://codereview.chromium.org/14173003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:737: final
Map<String, Iterable<ClassElement>> specializedGetInterceptors;
On 2013/04/11 15:17:50, floitsch wrote:
> I think this should be a Set.

Done.

https://codereview.chromium.org/14173003/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:771: new
Map<String, Iterable<ClassElement>>(),
On 2013/04/11 15:17:50, floitsch wrote:
> Set

Done.

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-compiler.status
File tests/co19/co19-compiler.status (right):

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-compiler.stat...
tests/co19/co19-compiler.status:224: # issue xxx - using removed deprecated
methods.
On 2013/04/11 15:17:50, floitsch wrote:
> Don't forget to file an issue.
> Put the issue number next to each test then (see above).

Done.

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-dart2js.statu...
tests/co19/co19-dart2js.status:370: # issue xxx - using removed deprecated
methods.
On 2013/04/11 15:17:50, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/14173003/diff/1/tests/co19/co19-runtime.statu...
tests/co19/co19-runtime.status:8: # issue xxx - using removed deprecated
methods.
On 2013/04/11 15:17:50, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/14173003/diff/1/utils/pub/utils.dart
File utils/pub/utils.dart (right):

https://codereview.chromium.org/14173003/diff/1/utils/pub/utils.dart#newcode336
utils/pub/utils.dart:336: /// Takes a simple data structure (composed of [Map]s,
[List]s, scalar objects,
On 2013/04/11 20:36:19, nweiz wrote:
> "[List]s" -> "[Iterable]s"

Done.

https://codereview.chromium.org/14173003/diff/1/utils/pub/utils.dart#newcode342
utils/pub/utils.dart:342: if (object is List || object is Set) {
On 2013/04/11 20:36:19, nweiz wrote:
> I think this should be "object is Iterable".

Done.

[Anders Johnsen, 2013-04-12 09:35:58]

Committed patchset #3 manually as r21338 (presubmit successful).