Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 14173003: Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org, srdjan, nweiz
Visibility:
Public.

Description

Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21338

Patch Set 1 #

Total comments: 26

Patch Set 2 : Review feedback. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -1769 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/ast_include.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 4 chunks +9 lines, -13 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 1 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 1 2 4 chunks +10 lines, -9 lines 0 comments Download
M pkg/args/lib/args.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/schedule.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/src/schedule_error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/matcher.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/unittest/lib/src/collection_matchers.dart View 1 chunk +0 lines, -201 lines 0 comments Download
M pkg/unittest/lib/src/core_matchers.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/unittest/lib/src/iterable_matchers.dart View 4 chunks +9 lines, -24 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/yaml/lib/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/array.dart View 1 4 chunks +2 lines, -23 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 3 chunks +2 lines, -10 lines 0 comments Download
M runtime/lib/typeddata.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/Views.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/layout/ViewLayout.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/view/view.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_collection_dev/to_string.dart View 6 chunks +29 lines, -29 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/emitter.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 2 chunks +1 line, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/mirrors/util.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/collections.dart View 1 4 chunks +0 lines, -110 lines 0 comments Download
M sdk/lib/collection/hash_set.dart View 2 chunks +2 lines, -13 lines 0 comments Download
M sdk/lib/collection/list.dart View 1 1 chunk +0 lines, -15 lines 0 comments Download
M sdk/lib/collection/queue.dart View 6 chunks +6 lines, -14 lines 0 comments Download
D sdk/lib/core/collection.dart View 1 chunk +0 lines, -96 lines 0 comments Download
M sdk/lib/core/core.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/corelib_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/core/list.dart View 1 4 chunks +22 lines, -13 lines 0 comments Download
M sdk/lib/core/set.dart View 3 chunks +27 lines, -7 lines 0 comments Download
M sdk/lib/core/string.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 49 chunks +8 lines, -418 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 50 chunks +10 lines, -432 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 1 1 chunk +0 lines, -18 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 6 chunks +0 lines, -48 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 6 chunks +0 lines, -48 lines 0 comments Download
M sdk/lib/typeddata/typeddata.dart View 1 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 1 chunk +15 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +19 lines, -1 line 0 comments Download
D tests/corelib/collection_contains_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
M tests/corelib/collection_removes_test.dart View 7 chunks +8 lines, -16 lines 0 comments Download
M tests/corelib/is_operator_basic_types_test.dart View 3 chunks +0 lines, -6 lines 0 comments Download
A + tests/corelib/iterable_contains_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib/queue_test.dart View 2 chunks +6 lines, -13 lines 0 comments Download
M tests/corelib/set_test.dart View 4 chunks +1 line, -5 lines 0 comments Download
M tests/language/generic_native_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/src/AttributeMap.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/src/CssClassSet.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 3 chunks +1 line, -17 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 3 chunks +1 line, -14 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Storage.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 1 1 chunk +0 lines, -8 lines 0 comments Download
M utils/pub/utils.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-11 13:41:58 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart File editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart (right): https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart#newcode260 editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:260: class ListWrapper<E> extends Iterable<E> implements List<E> { I'm ...
7 years, 8 months ago (2013-04-11 15:17:50 UTC) #2
floitsch
7 years, 8 months ago (2013-04-11 15:18:31 UTC) #3
nweiz
The pub and pkg changes lgtm, mod a few changes. Thanks for CCing me on ...
7 years, 8 months ago (2013-04-11 20:36:19 UTC) #4
Anders Johnsen
Thank you, both, for the comments. Landing. https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart File editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart (right): https://codereview.chromium.org/14173003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart#newcode260 editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:260: class ListWrapper<E> ...
7 years, 8 months ago (2013-04-12 09:31:14 UTC) #5
Anders Johnsen
7 years, 8 months ago (2013-04-12 09:35:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r21338 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698