sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart - Issue 14173003: Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

Issue 14173003: Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/js_array.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

index 9b271ba91845c0ecf3d9c5002739ef80600bf6bf..c86321f76324e716aa44acd0d9d93f22348b27f9 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

@@ -87,7 +87,7 @@ Dart2JsTypeMirror _convertTypeToTypeMirror(

system.compiler.internalError("Unexpected type $type of kind ${type.kind}");

}

-Collection<Dart2JsMemberMirror> _convertElementMemberToMemberMirrors(

+Iterable<Dart2JsMemberMirror> _convertElementMemberToMemberMirrors(

Dart2JsContainerMirror library, Element element) {

if (element.isSynthesized) {

return const <Dart2JsMemberMirror>[];

@@ -1655,7 +1655,7 @@ class Dart2JsMapConstantMirror extends Dart2JsConstantMirror

int get length => _constant.length;

- Collection<String> get keys {

+ Iterable<String> get keys {

// TODO(johnniwinther): Return an unmodifiable list instead.

return new List<String>.from(_list);

}