Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove.

pkg/analyzer_experimental/lib/src/generated/element.dart

 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine.element;
 
 import 'dart:collection';
 import 'java_core.dart';
 import 'java_engine.dart';
 import 'source.dart';
 import 'scanner.dart' show Keyword;
@@ skipping 1259 matching lines @@
   static List<ClassElement> EMPTY_ARRAY = new List<ClassElement>(0);
   /**
    * Initialize a newly created class element to have the given name.
    * @param name the name of this element
    */
   ClassElementImpl(Identifier name) : super.con1(name) {
   }
   accept(ElementVisitor visitor) => visitor.visitClassElement(this);
   List<PropertyAccessorElement> get accessors => _accessors;
   List<InterfaceType> get allSupertypes {
-    Collection<InterfaceType> list = new Set<InterfaceType>();
+    Iterable<InterfaceType> list = new Set<InterfaceType>();

[floitsch, 2013/04/11 15:17:50]

Set and the name should be replaced from 'list' to 'set' :)

[Anders Johnsen, 2013/04/12 09:31:14]

Done.

     collectAllSupertypes(list);
     return new List.from(list);
   }
   ElementImpl getChild(String identifier25) {
     for (PropertyAccessorElement accessor in _accessors) {
       if (((accessor as PropertyAccessorElementImpl)).identifier == identifier25) {
         return accessor as PropertyAccessorElementImpl;
       }
     }
     for (ConstructorElement constructor in _constructors) {
@@ skipping 243 matching lines @@
       builder.append("<");
       for (int i = 0; i < variableCount; i++) {
         if (i > 0) {
           builder.append(", ");
         }
         ((_typeVariables[i] as TypeVariableElementImpl)).appendTo(builder);
       }
       builder.append(">");
     }
   }
-  void collectAllSupertypes(Collection<InterfaceType> list) {
+  void collectAllSupertypes(Iterable<InterfaceType> list) {

[floitsch, 2013/04/11 15:17:50]

No. There is an 'add' call in line 1548.
Make it 'var'.

[Anders Johnsen, 2013/04/12 09:31:14]

Done.

     if (_supertype == null || list.contains(_supertype)) {
       return;
     }
     list.add(_supertype);
     ((_supertype.element as ClassElementImpl)).collectAllSupertypes(list);
     for (InterfaceType type in interfaces) {
       if (!list.contains(type)) {
         list.add(type);
         ((type.element as ClassElementImpl)).collectAllSupertypes(list);
       }
@@ skipping 3351 matching lines @@
  */
 abstract class TypeVariableType implements Type2 {
   TypeVariableElement get element;
 }
 /**
  * The interface {@code VoidType} defines the behavior of the unique object representing the type{@code void}.
  * @coverage dart.engine.type
  */
 abstract class VoidType implements Type2 {
   VoidType substitute2(List<Type2> argumentTypes, List<Type2> parameterTypes);
-}
+}