Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: runtime/lib/array.dart

Issue 14173003: Remove Collection, Collections and clean up List/Set/Queue implementations of retain/remove. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/yaml/lib/parser.dart ('k') | runtime/lib/growable_array.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/array.dart
diff --git a/runtime/lib/array.dart b/runtime/lib/array.dart
index a4182b8f7c019f413a6abffa99f0304fcc0f89e0..0ee4d081058a604b9d51d7dab38d7cfef9ce3bad 100644
--- a/runtime/lib/array.dart
+++ b/runtime/lib/array.dart
@@ -13,7 +13,7 @@ class _ObjectArray<E> implements List<E> {
void operator []=(int index, E value) native "ObjectArray_setIndexed";
String toString() {
- return Collections.collectionToString(this);
+ return ToString.iterableToString(this);
}
int get length native "ObjectArray_getLength";
@@ -39,17 +39,6 @@ class _ObjectArray<E> implements List<E> {
"Cannot remove element of a non-extendable array");
}
- // Collection interface.
- void removeAll(Iterable elements) {
- throw new UnsupportedError(
- "Cannot remove element of a non-extendable array");
- }
-
- void retainAll(Iterable elements) {
- throw new UnsupportedError(
- "Cannot remove element of a non-extendable array");
- }
-
void removeWhere(bool test(E element)) {
throw new UnsupportedError(
"Cannot remove element of a non-extendable array");
@@ -288,16 +277,6 @@ class _ImmutableArray<E> implements List<E> {
"Cannot modify an immutable array");
}
- void removeAll(Iterable elements) {
- throw new UnsupportedError(
- "Cannot modify an immutable array");
- }
-
- void retainAll(Iterable elements) {
- throw new UnsupportedError(
- "Cannot modify an immutable array");
- }
-
void removeWhere(bool test(E element)) {
throw new UnsupportedError(
"Cannot modify an immutable array");
@@ -429,7 +408,7 @@ class _ImmutableArray<E> implements List<E> {
}
String toString() {
- return Collections.collectionToString(this);
+ return ToString.iterableToString(this);
}
int indexOf(E element, [int start = 0]) {
« no previous file with comments | « pkg/yaml/lib/parser.dart ('k') | runtime/lib/growable_array.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698