Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 14079003: Implement Symbol correctly in dart2js. (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, regis, karlklose, ngeoffray
Visibility:
Public.

Description

Implement Symbol correctly in dart2js. Committed: https://code.google.com/p/dart/source/detail?r=21694

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix diagnostics and constructor refernces #

Patch Set 3 : Test status update and a few nits found during testing. #

Total comments: 4

Patch Set 4 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -57 lines) Patch
M dart/pkg/pkg.status View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/lib/symbol_patch.dart View 1 chunk +1 line, -37 lines 0 comments Download
M dart/sdk/lib/_collection_dev/symbol.dart View 3 chunks +40 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 3 5 chunks +49 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 9 chunks +75 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 1 chunk +12 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/warnings.dart View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
M dart/tests/corelib/corelib.status View 2 chunks +0 lines, -12 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/lib/lib.status View 1 chunk +1 line, -1 line 0 comments Download
A dart/tests/lib/mirrors/get_symbol_name_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
Johnni, I'm about to leave for an appointent with my car mechanic, but I wanted ...
7 years, 8 months ago (2013-04-18 11:34:44 UTC) #1
ahe
Nicolas, Karl, I'd also appreciate your comments. Cheers, Peter
7 years, 8 months ago (2013-04-18 11:35:32 UTC) #2
ahe
I have addressed all the problems I pointed out myself.
7 years, 8 months ago (2013-04-18 13:48:23 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/14079003/diff/13001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart File dart/sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/14079003/diff/13001/dart/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode684 dart/sdk/lib/_internal/compiler/implementation/compiler.dart:684: // The following classes may not exist. classes? ...
7 years, 8 months ago (2013-04-18 19:01:39 UTC) #4
ahe
Thank you for taking a look. I have tried addressing your comments, let me know ...
7 years, 8 months ago (2013-04-18 19:23:47 UTC) #5
ahe
7 years, 8 months ago (2013-04-18 19:25:40 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r21694 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698