dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart - Issue 14079003: Implement Symbol correctly in dart2js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart

Issue 14079003: Implement Symbol correctly in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart b/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart

index cd2608ab347ac0ca15bfbe1f5f2a467e80b83f97..dda7d3db3e087d5075e8c1740cc14e0792194f11 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart

@@ -5,6 +5,7 @@

// Patch library for dart:mirrors.

import 'dart:_foreign_helper' show JS;

+import "dart:_collection-dev" as _symbol_dev;

// Yeah, seriously: mirrors in dart2js are experimental...

const String _MIRROR_OPT_IN_MESSAGE = """

@@ -25,8 +26,7 @@ bool _mirrorsEnabled = false;

patch class MirrorSystem {

patch static String getName(Symbol symbol) {

- throw new UnimplementedError('MirrorSystem.getName is not yet implemented '

- 'in dart2js');

+ return _symbol_dev.Symbol.getName(symbol);

}