Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 14079003: Implement Symbol correctly in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
index 86e10e04a3785f771cbbc34ddc9eca03482bf31e..d363676fc67c67bca60a2f4abefc93617b661c1b 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
@@ -20,6 +20,7 @@ import 'dart:_interceptors' show getInterceptor,
setDispatchProperty,
Interceptor,
JSIndexable;
+import "dart:_collection-dev" as _symbol_dev;
part 'constant_map.dart';
part 'native_helper.dart';
@@ -63,7 +64,7 @@ String S(value) {
}
createInvocationMirror(name, internalName, type, arguments, argumentNames) {
- return new JSInvocationMirror(new Symbol(name),
+ return new JSInvocationMirror(new _symbol_dev.Symbol.unvalidated(name),
internalName,
type,
arguments,
@@ -111,7 +112,7 @@ class JSInvocationMirror implements Invocation {
int namedArgumentCount = _namedArgumentNames.length;
int namedArgumentsStartIndex = _arguments.length - namedArgumentCount;
for (int i = 0; i < namedArgumentCount; i++) {
- map[new Symbol(_namedArgumentNames[i])] =
+ map[new _symbol_dev.Symbol.unvalidated(_namedArgumentNames[i])] =
_arguments[namedArgumentsStartIndex + i];
}
return map;

Powered by Google App Engine
This is Rietveld 408576698