Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 14079003: Implement Symbol correctly in dart2js. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | dart/tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/warnings.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/warnings.dart b/dart/sdk/lib/_internal/compiler/implementation/warnings.dart
index 49c112e669e65d40f06ddbe6bacf141a38072691..014415d8168f8c1c15705ed548776cd15433895e 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/warnings.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/warnings.dart
@@ -393,6 +393,27 @@ Length: #{length}''');
"Error: Modifier static is only allowed on functions declared in"
" a class.");
+ static const STATIC_FUNCTION_BLOAT = const MessageKind(
+ 'Warning: Using "#{class}.#{name}" may result in larger output.');
+
+ static const NON_CONST_BLOAT = const MessageKind('''
+Warning: Using "new #{name}" may result in larger output.
+Use "const #{name}" if possible.''');
+
+ static const STRING_EXPECTED = const MessageKind(
+ 'Error: Expected a "String", but got an instance of "#{type}".');
+
+ static const PRIVATE_IDENTIFIER = const MessageKind(
+ 'Error: "#{value}" is not a valid Symbol name because it starts with '
+ '"_".');
+
+ static const INVALID_SYMBOL = const MessageKind('''
+Error: "#{value}" is not a valid Symbol name because is not:
+ * an empty String,
+ * a user defined operator,
+ * a qualified non-private identifier optionally followed by "=", or
+ * a qualified non-private identifier followed by "." and a user-defined operator.''');
+
static const COMPILER_CRASHED = const MessageKind(
"Error: The compiler crashed when compiling this element.");
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | dart/tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698