Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14065011: Implement getRange (returning an Iterable). (Closed)

Created:
7 years, 8 months ago by floitsch
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, srdjan
Visibility:
Public.

Description

Implement getRange (returning an Iterable). Committed: https://code.google.com/p/dart/source/detail?r=21281

Patch Set 1 #

Patch Set 2 : Rebuild dom libraries. #

Patch Set 3 : Fixes and status-file update. #

Total comments: 12

Patch Set 4 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -326 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/array.dart View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M runtime/lib/typeddata.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/collections.dart View 1 2 3 3 chunks +11 lines, -2 lines 0 comments Download
M sdk/lib/collection/list.dart View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M sdk/lib/core/list.dart View 1 2 3 2 chunks +20 lines, -4 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 34 chunks +103 lines, -100 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 34 chunks +103 lines, -100 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 6 chunks +18 lines, -18 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 6 chunks +18 lines, -18 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M tests/corelib/list_get_range_test.dart View 1 2 3 1 chunk +62 lines, -48 lines 0 comments Download
A + tests/corelib/list_sublist_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +5 lines, -3 lines 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
floitsch
7 years, 8 months ago (2013-04-10 16:29:45 UTC) #1
floitsch
Some fixes and a status file update.
7 years, 8 months ago (2013-04-10 20:48:25 UTC) #2
floitsch
7 years, 8 months ago (2013-04-10 20:53:10 UTC) #3
blois
DOM changes lgtm.
7 years, 8 months ago (2013-04-10 20:56:59 UTC) #4
Lasse Reichstein Nielsen
lgtm https://chromiumcodereview.appspot.com/14065011/diff/4001/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://chromiumcodereview.appspot.com/14065011/diff/4001/sdk/lib/core/list.dart#newcode238 sdk/lib/core/list.dart:238: * Say what happens if the length of ...
7 years, 8 months ago (2013-04-11 10:56:15 UTC) #5
floitsch
https://chromiumcodereview.appspot.com/14065011/diff/4001/sdk/lib/core/list.dart File sdk/lib/core/list.dart (right): https://chromiumcodereview.appspot.com/14065011/diff/4001/sdk/lib/core/list.dart#newcode238 sdk/lib/core/list.dart:238: * On 2013/04/11 10:56:15, Lasse Reichstein Nielsen wrote: > ...
7 years, 8 months ago (2013-04-11 14:12:48 UTC) #6
floitsch
7 years, 8 months ago (2013-04-11 14:15:03 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 manually as r21281 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698