Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 14065011: Implement getRange (returning an Iterable). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 1e0009da387e7fc61f2f9e03dc3b7880f8ab9a84..e10b483dd0c81c8cefff5661b11eb6dfe7c0e7b2 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -7001,14 +7001,14 @@ class DomMimeTypeArray implements JavaScriptIndexingBehavior, List<DomMimeType>
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<DomMimeType> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<DomMimeType> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <DomMimeType>[]);
}
- List<DomMimeType> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, DomMimeType> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -7271,14 +7271,14 @@ class DomPluginArray implements JavaScriptIndexingBehavior, List<DomPlugin> nati
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<DomPlugin> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<DomPlugin> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <DomPlugin>[]);
}
- List<DomPlugin> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, DomPlugin> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -7689,14 +7689,14 @@ class DomStringList implements JavaScriptIndexingBehavior, List<String> native "
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<String> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<String> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <String>[]);
}
- List<String> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, String> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -7959,14 +7959,15 @@ class _ChildrenElementList extends ListBase<Element> {
throw new UnimplementedError();
}
+ Iterable getRange(int start, int end) {
+ throw new UnimplementedError();
+ }
+
List sublist(int start, [int end]) {
if (end == null) end = length;
return new _FrozenElementList._wrap(Lists.getRange(this, start, end, []));
}
- List getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
int indexOf(Element element, [int start = 0]) {
return Lists.indexOf(this, element, start, this.length);
}
@@ -10436,14 +10437,14 @@ class FileList implements JavaScriptIndexingBehavior, List<File> native "*FileLi
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<File> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<File> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <File>[]);
}
- List<File> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, File> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -10928,14 +10929,14 @@ class Float32Array extends ArrayBufferView implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<num> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<num> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <num>[]);
}
- List<num> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, num> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -11162,14 +11163,14 @@ class Float64Array extends ArrayBufferView implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<num> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<num> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <num>[]);
}
- List<num> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, num> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -11816,14 +11817,14 @@ class HtmlAllCollection implements JavaScriptIndexingBehavior, List<Node> native
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -12039,14 +12040,14 @@ class HtmlCollection implements JavaScriptIndexingBehavior, List<Node> native "*
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -14085,14 +14086,14 @@ class Int16Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -14319,14 +14320,14 @@ class Int32Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -14553,14 +14554,14 @@ class Int8Array extends ArrayBufferView implements JavaScriptIndexingBehavior, L
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -17009,14 +17010,16 @@ class _ChildNodeListLazy extends ListBase<Node> {
throw new UnsupportedError(
"Cannot insertRange on immutable List.");
}
+
+ Iterable<Node> getRange(int start, int end) {
+ throw new UnimplementedError("NodeList.getRange");
+ }
+
List<Node> sublist(int start, [int end]) {
if (end == null) end == length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
String toString() {
StringBuffer buffer = new StringBuffer('[');
buffer.writeAll(this, ', ');
@@ -17582,14 +17585,14 @@ class NodeList implements JavaScriptIndexingBehavior, List<Node> native "*NodeLi
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -19934,14 +19937,14 @@ class SourceBufferList extends EventTarget implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SourceBuffer> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SourceBuffer> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SourceBuffer>[]);
}
- List<SourceBuffer> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SourceBuffer> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -20230,14 +20233,14 @@ class SpeechGrammarList implements JavaScriptIndexingBehavior, List<SpeechGramma
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SpeechGrammar> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SpeechGrammar> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SpeechGrammar>[]);
}
- List<SpeechGrammar> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SpeechGrammar> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -21689,14 +21692,14 @@ class TextTrackCueList implements List<TextTrackCue>, JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<TextTrackCue> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<TextTrackCue> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <TextTrackCue>[]);
}
- List<TextTrackCue> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, TextTrackCue> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -21910,14 +21913,14 @@ class TextTrackList extends EventTarget implements JavaScriptIndexingBehavior, L
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<TextTrack> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<TextTrack> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <TextTrack>[]);
}
- List<TextTrack> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, TextTrack> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -22357,14 +22360,14 @@ class TouchList implements JavaScriptIndexingBehavior, List<Touch> native "*Touc
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Touch> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Touch> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Touch>[]);
}
- List<Touch> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Touch> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -22841,14 +22844,14 @@ class Uint16Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -23075,14 +23078,14 @@ class Uint32Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -23309,14 +23312,14 @@ class Uint8Array extends ArrayBufferView implements JavaScriptIndexingBehavior,
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -23540,14 +23543,14 @@ class Uint8ClampedArray extends Uint8Array implements JavaScriptIndexingBehavior
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -25822,14 +25825,14 @@ class _ClientRectList implements JavaScriptIndexingBehavior, List<Rect> native "
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Rect> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Rect> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Rect>[]);
}
- List<Rect> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Rect> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -26044,14 +26047,14 @@ class _CssRuleList implements JavaScriptIndexingBehavior, List<CssRule> native "
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<CssRule> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<CssRule> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <CssRule>[]);
}
- List<CssRule> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, CssRule> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -26257,14 +26260,14 @@ class _CssValueList extends _CSSValue implements JavaScriptIndexingBehavior, Lis
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<_CSSValue> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<_CSSValue> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <_CSSValue>[]);
}
- List<_CSSValue> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, _CSSValue> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -26538,14 +26541,14 @@ class _EntryArray implements JavaScriptIndexingBehavior, List<Entry> native "*En
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Entry> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Entry> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Entry>[]);
}
- List<Entry> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Entry> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -26751,14 +26754,14 @@ class _EntryArraySync implements JavaScriptIndexingBehavior, List<_EntrySync> na
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<_EntrySync> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<_EntrySync> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <_EntrySync>[]);
}
- List<_EntrySync> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, _EntrySync> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -27007,14 +27010,14 @@ class _GamepadList implements JavaScriptIndexingBehavior, List<Gamepad> native "
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Gamepad> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Gamepad> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Gamepad>[]);
}
- List<Gamepad> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Gamepad> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -27283,14 +27286,14 @@ class _NamedNodeMap implements JavaScriptIndexingBehavior, List<Node> native "*N
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -27567,14 +27570,14 @@ class _SpeechInputResultList implements JavaScriptIndexingBehavior, List<SpeechI
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SpeechInputResult> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SpeechInputResult> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SpeechInputResult>[]);
}
- List<SpeechInputResult> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SpeechInputResult> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -27780,14 +27783,14 @@ class _SpeechRecognitionResultList implements JavaScriptIndexingBehavior, List<S
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SpeechRecognitionResult> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SpeechRecognitionResult> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SpeechRecognitionResult>[]);
}
- List<SpeechRecognitionResult> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SpeechRecognitionResult> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -27993,14 +27996,14 @@ class _StyleSheetList implements JavaScriptIndexingBehavior, List<StyleSheet> na
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<StyleSheet> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<StyleSheet> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <StyleSheet>[]);
}
- List<StyleSheet> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, StyleSheet> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -31123,7 +31126,7 @@ class _WrappedList<E> implements List<E> {
List<E> sublist(int start, [int end]) => _list.sublist(start, end);
- List<E> getRange(int start, int length) => sublist(start, start + length);
+ Iterable<E> getRange(int start, int end) => _list.getRange(start, end);
void setRange(int start, int length, List<E> from, [int startFrom]) {
_list.setRange(start, length, from, startFrom);
« no previous file with comments | « sdk/lib/core/list.dart ('k') | sdk/lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698