Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 14065011: Implement getRange (returning an Iterable). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/filtered_element_list.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index efb890a20e466a0b65d93e62f642df64d46bc83e..4d89bc4c3e0ffcc35194936caa78f822d6246710 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -7572,14 +7572,14 @@ class DomMimeTypeArray extends NativeFieldWrapperClass1 implements List<DomMimeT
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<DomMimeType> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<DomMimeType> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <DomMimeType>[]);
}
- List<DomMimeType> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, DomMimeType> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -7856,14 +7856,14 @@ class DomPluginArray extends NativeFieldWrapperClass1 implements List<DomPlugin>
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<DomPlugin> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<DomPlugin> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <DomPlugin>[]);
}
- List<DomPlugin> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, DomPlugin> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -8292,14 +8292,14 @@ class DomStringList extends NativeFieldWrapperClass1 implements List<String> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<String> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<String> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <String>[]);
}
- List<String> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, String> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -8583,14 +8583,15 @@ class _ChildrenElementList extends ListBase<Element> {
throw new UnimplementedError();
}
+ Iterable getRange(int start, int end) {
+ throw new UnimplementedError();
+ }
+
List sublist(int start, [int end]) {
if (end == null) end = length;
return new _FrozenElementList._wrap(Lists.getRange(this, start, end, []));
}
- List getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
int indexOf(Element element, [int start = 0]) {
return Lists.indexOf(this, element, start, this.length);
}
@@ -10986,14 +10987,14 @@ class FileList extends NativeFieldWrapperClass1 implements List<File> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<File> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<File> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <File>[]);
}
- List<File> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, File> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -11508,14 +11509,14 @@ class Float32Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<num> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<num> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <num>[]);
}
- List<num> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, num> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -11759,14 +11760,14 @@ class Float64Array extends ArrayBufferView implements List<double> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<num> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<num> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <num>[]);
}
- List<num> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, num> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -12459,14 +12460,14 @@ class HtmlAllCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -12684,14 +12685,14 @@ class HtmlCollection extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -15065,14 +15066,14 @@ class Int16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -15316,14 +15317,14 @@ class Int32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -15567,14 +15568,14 @@ class Int8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -18317,14 +18318,16 @@ class _ChildNodeListLazy extends ListBase<Node> {
throw new UnsupportedError(
"Cannot insertRange on immutable List.");
}
+
+ Iterable<Node> getRange(int start, int end) {
+ throw new UnimplementedError("NodeList.getRange");
+ }
+
List<Node> sublist(int start, [int end]) {
if (end == null) end == length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
String toString() {
StringBuffer buffer = new StringBuffer('[');
buffer.writeAll(this, ', ');
@@ -18888,14 +18891,14 @@ class NodeList extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -21523,14 +21526,14 @@ class SourceBufferList extends EventTarget implements List<SourceBuffer> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SourceBuffer> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SourceBuffer> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SourceBuffer>[]);
}
- List<SourceBuffer> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SourceBuffer> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -21857,14 +21860,14 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SpeechGrammar> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SpeechGrammar> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SpeechGrammar>[]);
}
- List<SpeechGrammar> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SpeechGrammar> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -23606,14 +23609,14 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List<TextTrac
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<TextTrackCue> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<TextTrackCue> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <TextTrackCue>[]);
}
- List<TextTrackCue> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, TextTrackCue> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -23831,14 +23834,14 @@ class TextTrackList extends EventTarget implements List<TextTrack> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<TextTrack> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<TextTrack> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <TextTrack>[]);
}
- List<TextTrack> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, TextTrack> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -24273,14 +24276,14 @@ class TouchList extends NativeFieldWrapperClass1 implements List<Touch> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Touch> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Touch> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Touch>[]);
}
- List<Touch> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Touch> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -24798,14 +24801,14 @@ class Uint16Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -25049,14 +25052,14 @@ class Uint32Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -25300,14 +25303,14 @@ class Uint8Array extends ArrayBufferView implements List<int> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -25549,14 +25552,14 @@ class Uint8ClampedArray extends Uint8Array implements List<int> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<int> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<int> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <int>[]);
}
- List<int> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, int> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -27663,14 +27666,14 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List<Rect> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Rect> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Rect> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Rect>[]);
}
- List<Rect> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Rect> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -27893,14 +27896,14 @@ class _CssRuleList extends NativeFieldWrapperClass1 implements List<CssRule> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<CssRule> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<CssRule> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <CssRule>[]);
}
- List<CssRule> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, CssRule> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -28110,14 +28113,14 @@ class _CssValueList extends _CSSValue implements List<_CSSValue> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<_CSSValue> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<_CSSValue> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <_CSSValue>[]);
}
- List<_CSSValue> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, _CSSValue> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -28563,14 +28566,14 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List<Entry> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Entry> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Entry> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Entry>[]);
}
- List<Entry> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Entry> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -28780,14 +28783,14 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<_EntrySyn
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<_EntrySync> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<_EntrySync> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <_EntrySync>[]);
}
- List<_EntrySync> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, _EntrySync> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -29058,14 +29061,14 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List<Gamepad> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Gamepad> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Gamepad> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Gamepad>[]);
}
- List<Gamepad> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Gamepad> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -29366,14 +29369,14 @@ class _NamedNodeMap extends NativeFieldWrapperClass1 implements List<Node> {
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Node> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Node> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Node>[]);
}
- List<Node> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Node> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -29668,14 +29671,14 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List<Sp
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SpeechInputResult> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SpeechInputResult> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SpeechInputResult>[]);
}
- List<SpeechInputResult> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SpeechInputResult> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -29885,14 +29888,14 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<SpeechRecognitionResult> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<SpeechRecognitionResult> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <SpeechRecognitionResult>[]);
}
- List<SpeechRecognitionResult> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, SpeechRecognitionResult> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -30102,14 +30105,14 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List<StyleShee
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<StyleSheet> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<StyleSheet> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <StyleSheet>[]);
}
- List<StyleSheet> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, StyleSheet> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -32678,7 +32681,7 @@ class _WrappedList<E> implements List<E> {
List<E> sublist(int start, [int end]) => _list.sublist(start, end);
- List<E> getRange(int start, int length) => sublist(start, start + length);
+ Iterable<E> getRange(int start, int end) => _list.getRange(start, end);
void setRange(int start, int length, List<E> from, [int startFrom]) {
_list.setRange(start, length, from, startFrom);
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | sdk/lib/html/html_common/filtered_element_list.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698