Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 14065011: Implement getRange (returning an Iterable). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/html_common/filtered_element_list.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/svg/dart2js/svg_dart2js.dart
diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart
index 207e81f5d7a1a24b008510652338e5c133cf5b38..61dc2f280b1f7e2267fe5c35905b1fe7ec215e35 100644
--- a/sdk/lib/svg/dart2js/svg_dart2js.dart
+++ b/sdk/lib/svg/dart2js/svg_dart2js.dart
@@ -3187,14 +3187,14 @@ class LengthList implements JavaScriptIndexingBehavior, List<Length> native "*SV
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Length> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Length> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Length>[]);
}
- List<Length> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Length> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -3827,14 +3827,14 @@ class NumberList implements JavaScriptIndexingBehavior, List<Number> native "*SV
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Number> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Number> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Number>[]);
}
- List<Number> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Number> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -4698,14 +4698,14 @@ class PathSegList implements JavaScriptIndexingBehavior, List<PathSeg> native "*
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<PathSeg> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<PathSeg> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <PathSeg>[]);
}
- List<PathSeg> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, PathSeg> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -5599,14 +5599,14 @@ class StringList implements JavaScriptIndexingBehavior, List<String> native "*SV
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<String> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<String> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <String>[]);
}
- List<String> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, String> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -6773,14 +6773,14 @@ class TransformList implements List<Transform>, JavaScriptIndexingBehavior nativ
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<Transform> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<Transform> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <Transform>[]);
}
- List<Transform> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, Transform> asMap() =>
IterableMixinWorkaround.asMapList(this);
@@ -7308,14 +7308,14 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List<ElementIn
throw new UnsupportedError("Cannot insertRange on immutable List.");
}
+ Iterable<ElementInstance> getRange(int start, int end) =>
+ IterableMixinWorkaround.getRangeList(this, start, end);
+
List<ElementInstance> sublist(int start, [int end]) {
if (end == null) end = length;
return Lists.getRange(this, start, end, <ElementInstance>[]);
}
- List<ElementInstance> getRange(int start, int rangeLength) =>
- sublist(start, start + rangeLength);
-
Map<int, ElementInstance> asMap() =>
IterableMixinWorkaround.asMapList(this);
« no previous file with comments | « sdk/lib/html/html_common/filtered_element_list.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698