Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1379203002: Refactor groups to pipe them through to the runner. (Closed)

Created:
5 years, 2 months ago by nweiz
Modified:
5 years, 2 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor groups to pipe them through to the runner. This is groundwork for #18 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/a9cfdc138e0873fd660ba015db2f5a12de325616

Patch Set 1 #

Patch Set 2 : Test fixes #

Total comments: 2

Patch Set 3 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+921 lines, -657 lines) Patch
M lib/src/backend/declarer.dart View 1 2 2 chunks +144 lines, -39 lines 0 comments Download
M lib/src/backend/group.dart View 1 chunk +31 lines, -81 lines 0 comments Download
M lib/src/backend/invoker.dart View 5 chunks +9 lines, -12 lines 0 comments Download
M lib/src/backend/metadata.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/backend/suite.dart View 3 chunks +24 lines, -24 lines 0 comments Download
A lib/src/backend/suite_entry.dart View 1 chunk +34 lines, -0 lines 0 comments Download
M lib/src/backend/test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M lib/src/frontend/throws_matcher.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/runner.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 1 2 chunks +26 lines, -6 lines 0 comments Download
M lib/src/runner/browser/iframe_listener.dart View 1 4 chunks +42 lines, -28 lines 0 comments Download
M lib/src/runner/browser/iframe_test.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M lib/src/runner/engine.dart View 5 chunks +68 lines, -53 lines 0 comments Download
M lib/src/runner/load_suite.dart View 4 chunks +9 lines, -2 lines 0 comments Download
M lib/src/runner/loader.dart View 3 chunks +19 lines, -6 lines 0 comments Download
M lib/src/runner/runner_suite.dart View 2 chunks +10 lines, -8 lines 0 comments Download
M lib/src/runner/vm/isolate_listener.dart View 4 chunks +36 lines, -21 lines 0 comments Download
M lib/src/runner/vm/isolate_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M lib/test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/backend/declarer_test.dart View 4 chunks +320 lines, -255 lines 0 comments Download
M test/runner/browser/loader_test.dart View 5 chunks +15 lines, -15 lines 0 comments Download
M test/runner/engine_test.dart View 4 chunks +56 lines, -42 lines 0 comments Download
M test/runner/isolate_listener_test.dart View 3 chunks +12 lines, -8 lines 0 comments Download
M test/runner/load_suite_test.dart View 7 chunks +22 lines, -22 lines 0 comments Download
M test/runner/loader_test.dart View 4 chunks +9 lines, -9 lines 0 comments Download
M test/utils.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 2 months ago (2015-10-01 21:51:21 UTC) #1
kevmoo
On 2015/10/01 21:51:21, nweiz wrote: pub run test test/runner/pub_serve_test.dart 01:42 +9 -1: with a failing ...
5 years, 2 months ago (2015-10-01 23:27:31 UTC) #2
kevmoo
lgtm https://codereview.chromium.org/1379203002/diff/20001/lib/src/backend/declarer.dart File lib/src/backend/declarer.dart (right): https://codereview.chromium.org/1379203002/diff/20001/lib/src/backend/declarer.dart#newcode27 lib/src/backend/declarer.dart:27: /// The name of the current test group, ...
5 years, 2 months ago (2015-10-02 18:27:21 UTC) #3
nweiz
https://codereview.chromium.org/1379203002/diff/20001/lib/src/backend/declarer.dart File lib/src/backend/declarer.dart (right): https://codereview.chromium.org/1379203002/diff/20001/lib/src/backend/declarer.dart#newcode27 lib/src/backend/declarer.dart:27: /// The name of the current test group, including ...
5 years, 2 months ago (2015-10-02 20:56:54 UTC) #4
nweiz
Code review changes
5 years, 2 months ago (2015-10-02 20:57:19 UTC) #5
nweiz
5 years, 2 months ago (2015-10-02 20:59:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a9cfdc138e0873fd660ba015db2f5a12de325616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698