Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: lib/src/runner/browser/iframe_listener.dart

Issue 1379203002: Refactor groups to pipe them through to the runner. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/browser_manager.dart ('k') | lib/src/runner/browser/iframe_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/iframe_listener.dart
diff --git a/lib/src/runner/browser/iframe_listener.dart b/lib/src/runner/browser/iframe_listener.dart
index 9da65771bfd5f7e96f57cf460e821a6db4112af9..40baf69c232c96fd99018fc47ea33cbc1c7c8044 100644
--- a/lib/src/runner/browser/iframe_listener.dart
+++ b/lib/src/runner/browser/iframe_listener.dart
@@ -9,8 +9,10 @@ import 'dart:convert';
import 'dart:html' hide Metadata;
import '../../backend/declarer.dart';
+import '../../backend/group.dart';
import '../../backend/metadata.dart';
import '../../backend/suite.dart';
+import '../../backend/suite_entry.dart';
import '../../backend/test.dart';
import '../../backend/test_platform.dart';
import '../../util/multi_channel.dart';
@@ -54,14 +56,18 @@ class IframeListener {
return;
}
- var declarer;
+ var url = Uri.parse(window.location.href);
+ var message = JSON.decode(Uri.decodeFull(url.fragment));
+ var metadata = new Metadata.deserialize(message['metadata']);
+
+ var declarer = new Declarer(metadata);
try {
- declarer = new Declarer();
- await runZoned(() => new Future.sync(main), zoneValues: {
- #test.declarer: declarer
- }, zoneSpecification: new ZoneSpecification(print: (_, __, ___, line) {
- channel.sink.add({"type": "print", "line": line});
- }));
+ await declarer.declare(() {
+ return runZoned(() => new Future.sync(main),
+ zoneSpecification: new ZoneSpecification(print: (_, __, ___, line) {
+ channel.sink.add({"type": "print", "line": line});
+ }));
+ });
} catch (error, stackTrace) {
channel.sink.add({
"type": "error",
@@ -70,13 +76,9 @@ class IframeListener {
return;
}
- var url = Uri.parse(window.location.href);
- var message = JSON.decode(Uri.decodeFull(url.fragment));
- var metadata = new Metadata.deserialize(message['metadata']);
var browser = TestPlatform.find(message['browser']);
-
- var suite = new Suite(
- declarer.tests, platform: browser, metadata: metadata);
+ var suite = new Suite(declarer.build(),
+ platform: browser, metadata: metadata);
new IframeListener._(suite)._listen(channel);
return;
@@ -125,29 +127,41 @@ class IframeListener {
/// Send information about [_suite] across [channel] and start listening for
/// commands to run the tests.
void _listen(MultiChannel channel) {
- var tests = [];
- for (var i = 0; i < _suite.tests.length; i++) {
- var test = _suite.tests[i];
- var testChannel = channel.virtualChannel();
- tests.add({
- "name": test.name,
- "metadata": test.metadata.serialize(),
- "channel": testChannel.id
- });
+ channel.sink.add({
+ "type": "success",
+ "entries": _serializeEntries(channel, _suite.entries)
+ });
+ }
+ /// Serializes [entries] into a JSON-safe map.
+ List<Map> _serializeEntries(MultiChannel channel, List<SuiteEntry> entries) {
+ return entries.map((entry) {
+ if (entry is Group) {
+ return {
+ "type": "group",
+ "name": entry.name,
+ "metadata": entry.metadata.serialize(),
+ "entries": _serializeEntries(channel, entry.entries)
+ };
+ }
+
+ var test = entry as Test;
+ var testChannel = channel.virtualChannel();
testChannel.stream.listen((message) {
assert(message['command'] == 'run');
_runTest(test, channel.virtualChannel(message['channel']));
});
- }
- channel.sink.add({
- "type": "success",
- "tests": tests
- });
+ return {
+ "type": "test",
+ "name": test.name,
+ "metadata": test.metadata.serialize(),
+ "channel": testChannel.id
+ };
+ }).toList();
}
- /// Runs [test] and sends the results across [sendPort].
+ /// Runs [test] and sends the results across [channel].
void _runTest(Test test, MultiChannel channel) {
var liveTest = test.load(_suite);
« no previous file with comments | « lib/src/runner/browser/browser_manager.dart ('k') | lib/src/runner/browser/iframe_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698