Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: test/runner/load_suite_test.dart

Issue 1379203002: Refactor groups to pipe them through to the runner. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/isolate_listener_test.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/load_suite_test.dart
diff --git a/test/runner/load_suite_test.dart b/test/runner/load_suite_test.dart
index 9af907572118207167791e6e92adb2b524f378f6..d37b83eaa684945d75579f55570b902a6cdec7e1 100644
--- a/test/runner/load_suite_test.dart
+++ b/test/runner/load_suite_test.dart
@@ -22,20 +22,20 @@ void main() {
test("running a load test causes LoadSuite.suite to emit a suite", () async {
var suite = new LoadSuite("name", () => new Future.value(innerSuite));
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
expect(suite.suite, completion(equals(innerSuite)));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
await liveTest.run();
expectTestPassed(liveTest);
});
test("running a load suite's body may be synchronous", () async {
var suite = new LoadSuite("name", () => innerSuite);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
expect(suite.suite, completion(equals(innerSuite)));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
await liveTest.run();
expectTestPassed(liveTest);
});
@@ -43,9 +43,9 @@ void main() {
test("a load test doesn't complete until the body returns", () async {
var completer = new Completer();
var suite = new LoadSuite("name", () => completer.future);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
expect(liveTest.run(), completes);
await new Future.delayed(Duration.ZERO);
expect(liveTest.state.status, equals(Status.running));
@@ -58,20 +58,20 @@ void main() {
test("a load test forwards errors and completes LoadSuite.suite to null",
() async {
var suite = new LoadSuite("name", () => fail("error"));
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
expect(suite.suite, completion(isNull));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
await liveTest.run();
expectTestFailed(liveTest, "error");
});
test("a load test completes early if it's closed", () async {
var suite = new LoadSuite("name", () => new Completer().future);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
expect(liveTest.run(), completes);
await new Future.delayed(Duration.ZERO);
expect(liveTest.state.status, equals(Status.running));
@@ -83,11 +83,11 @@ void main() {
() async {
var exception = new LoadException("path", "error");
var suite = new LoadSuite.forLoadException(exception);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
expect(suite.suite, completion(isNull));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
await liveTest.run();
expect(liveTest.state.status, equals(Status.complete));
expect(liveTest.state.result, equals(Result.error));
@@ -98,10 +98,10 @@ void main() {
test("forSuite() creates a load suite that completes to a test suite",
() async {
var suite = new LoadSuite.forSuite(innerSuite);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
expect(suite.suite, completion(equals(innerSuite)));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
await liveTest.run();
expectTestPassed(liveTest);
});
@@ -110,34 +110,34 @@ void main() {
test("returns a new load suite with the same properties", () {
var suite = new LoadSuite("name", () => innerSuite,
platform: TestPlatform.vm);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
var newSuite = suite.changeSuite((suite) => suite);
expect(newSuite.platform, equals(TestPlatform.vm));
- expect(newSuite.tests, equals(suite.tests));
+ expect(newSuite.entries.single.name, equals(suite.entries.single.name));
});
test("changes the inner suite", () async {
var suite = new LoadSuite("name", () => innerSuite);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
var newInnerSuite = new RunnerSuite(const VMEnvironment(), []);
var newSuite = suite.changeSuite((suite) => newInnerSuite);
expect(newSuite.suite, completion(equals(newInnerSuite)));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
await liveTest.run();
expectTestPassed(liveTest);
});
test("doesn't run change() if the suite is null", () async {
var suite = new LoadSuite("name", () => null);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
var newSuite = suite.changeSuite(expectAsync((_) {}, count: 0));
expect(newSuite.suite, completion(isNull));
- var liveTest = await suite.tests.single.load(suite);
+ var liveTest = await suite.entries.single.load(suite);
await liveTest.run();
expectTestPassed(liveTest);
});
@@ -146,14 +146,14 @@ void main() {
group("getSuite()", () {
test("runs the test and returns the suite", () {
var suite = new LoadSuite.forSuite(innerSuite);
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
expect(suite.getSuite(), completion(equals(innerSuite)));
});
test("forwards errors to the future", () {
var suite = new LoadSuite("name", () => throw "error");
- expect(suite.tests, hasLength(1));
+ expect(suite.entries, hasLength(1));
expect(suite.getSuite(), throwsA("error"));
});
« no previous file with comments | « test/runner/isolate_listener_test.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698