Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: test/runner/engine_test.dart

Issue 1379203002: Refactor groups to pipe them through to the runner. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/browser/loader_test.dart ('k') | test/runner/isolate_listener_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/engine_test.dart
diff --git a/test/runner/engine_test.dart b/test/runner/engine_test.dart
index 584d2cdd9758755253ef8c98bf74f4bbc87a4274..ecf27199f4d64e09f9466d63f9df0cd1457007ac 100644
--- a/test/runner/engine_test.dart
+++ b/test/runner/engine_test.dart
@@ -9,22 +9,23 @@ import 'package:test/src/runner/runner_suite.dart';
import 'package:test/src/runner/vm/environment.dart';
import 'package:test/test.dart';
-void main() {
- var declarer;
- setUp(() => declarer = new Declarer());
+import '../utils.dart';
+void main() {
test("runs each test in each suite in order", () async {
var testsRun = 0;
- for (var i = 0; i < 4; i++) {
- declarer.test("test ${i + 1}", expectAsync(() {
- expect(testsRun, equals(i));
- testsRun++;
- }, max: 1));
- }
+ var tests = declare(() {
+ for (var i = 0; i < 4; i++) {
+ test("test ${i + 1}", expectAsync(() {
+ expect(testsRun, equals(i));
+ testsRun++;
+ }, max: 1));
+ }
+ });
var engine = new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), declarer.tests.take(2)),
- new RunnerSuite(const VMEnvironment(), declarer.tests.skip(2))
+ new RunnerSuite(const VMEnvironment(), tests.take(2)),
+ new RunnerSuite(const VMEnvironment(), tests.skip(2))
]);
await engine.run();
@@ -33,32 +34,35 @@ void main() {
test("runs tests in a suite added after run() was called", () {
var testsRun = 0;
- for (var i = 0; i < 4; i++) {
- declarer.test("test ${i + 1}", expectAsync(() {
- expect(testsRun, equals(i));
- testsRun++;
- }, max: 1));
- }
+ var tests = declare(() {
+ for (var i = 0; i < 4; i++) {
+ test("test ${i + 1}", expectAsync(() {
+ expect(testsRun, equals(i));
+ testsRun++;
+ }, max: 1));
+ }
+ });
var engine = new Engine();
expect(engine.run().then((_) {
expect(testsRun, equals(4));
}), completes);
- engine.suiteSink.add(
- new RunnerSuite(const VMEnvironment(), declarer.tests));
+ engine.suiteSink.add(new RunnerSuite(const VMEnvironment(), tests));
engine.suiteSink.close();
});
test("emits each test before it starts running and after the previous test "
"finished", () {
var testsRun = 0;
- for (var i = 0; i < 3; i++) {
- declarer.test("test ${i + 1}", expectAsync(() => testsRun++, max: 1));
- }
+ var tests = declare(() {
+ for (var i = 0; i < 3; i++) {
+ test("test ${i + 1}", expectAsync(() => testsRun++, max: 1));
+ }
+ });
var engine = new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), declarer.tests)
+ new RunnerSuite(const VMEnvironment(), tests)
]);
engine.onTestStarted.listen(expectAsync((liveTest) {
@@ -75,36 +79,42 @@ void main() {
});
test(".run() returns true if every test passes", () {
- for (var i = 0; i < 2; i++) {
- declarer.test("test ${i + 1}", () {});
- }
+ var tests = declare(() {
+ for (var i = 0; i < 2; i++) {
+ test("test ${i + 1}", () {});
+ }
+ });
var engine = new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), declarer.tests)
+ new RunnerSuite(const VMEnvironment(), tests)
]);
expect(engine.run(), completion(isTrue));
});
test(".run() returns false if any test fails", () {
- for (var i = 0; i < 2; i++) {
- declarer.test("test ${i + 1}", () {});
- }
- declarer.test("failure", () => throw new TestFailure("oh no"));
+ var tests = declare(() {
+ for (var i = 0; i < 2; i++) {
+ test("test ${i + 1}", () {});
+ }
+ test("failure", () => throw new TestFailure("oh no"));
+ });
var engine = new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), declarer.tests)
+ new RunnerSuite(const VMEnvironment(), tests)
]);
expect(engine.run(), completion(isFalse));
});
test(".run() returns false if any test errors", () {
- for (var i = 0; i < 2; i++) {
- declarer.test("test ${i + 1}", () {});
- }
- declarer.test("failure", () => throw "oh no");
+ var tests = declare(() {
+ for (var i = 0; i < 2; i++) {
+ test("test ${i + 1}", () {});
+ }
+ test("failure", () => throw "oh no");
+ });
var engine = new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), declarer.tests)
+ new RunnerSuite(const VMEnvironment(), tests)
]);
expect(engine.run(), completion(isFalse));
});
@@ -118,25 +128,29 @@ void main() {
group("for a skipped test", () {
test("doesn't run the test's body", () async {
var bodyRun = false;
- declarer.test("test", () => bodyRun = true, skip: true);
+ var tests = declare(() {
+ test("test", () => bodyRun = true, skip: true);
+ });
var engine = new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), declarer.tests)
+ new RunnerSuite(const VMEnvironment(), tests)
]);
await engine.run();
expect(bodyRun, isFalse);
});
test("exposes a LiveTest that emits the correct states", () {
- declarer.test("test", () {}, skip: true);
+ var tests = declare(() {
+ test("test", () {}, skip: true);
+ });
var engine = new Engine.withSuites([
- new RunnerSuite(const VMEnvironment(), declarer.tests)
+ new RunnerSuite(const VMEnvironment(), tests)
]);
engine.onTestStarted.listen(expectAsync((liveTest) {
expect(liveTest, same(engine.liveTests.single));
- expect(liveTest.test, equals(declarer.tests.single));
+ expect(liveTest.test.name, equals(tests.single.name));
var first = true;
liveTest.onStateChange.listen(expectAsync((state) {
« no previous file with comments | « test/runner/browser/loader_test.dart ('k') | test/runner/isolate_listener_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698