Lookup getter/setter symbols before alllocating them, thus eliminating extra String allocations in …

Lookup getter/setter symbols before alllocating them, thus eliminating extra String allocations in new space.
Various old space allocations, cleanups.
Add a test for Symbols concatenation.

BUG=
R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/d4365bc6f41a13f6c76bd27503b16f2f7ceae12c

[srdjan, 2015-09-03 20:28:44]

srdjan@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-09-03 20:48:49]

LGTM with comment.

https://codereview.chromium.org/1320673012/diff/1/runtime/vm/ast.cc
File runtime/vm/ast.cc (right):

https://codereview.chromium.org/1320673012/diff/1/runtime/vm/ast.cc#newcode578
runtime/vm/ast.cc:578: setter =  Resolver::ResolveDynamicAnyArgs(cls(),
setter_name);
Extra space after =

https://codereview.chromium.org/1320673012/diff/1/runtime/vm/ast.cc#newcode695
runtime/vm/ast.cc:695: const String& getter_name =
Is getter_name_ guaranteed to be non-null? If not, handle the case.

[srdjan, 2015-09-03 20:55:36]

https://codereview.chromium.org/1320673012/diff/1/runtime/vm/ast.cc
File runtime/vm/ast.cc (right):

https://codereview.chromium.org/1320673012/diff/1/runtime/vm/ast.cc#newcode578
runtime/vm/ast.cc:578: setter =  Resolver::ResolveDynamicAnyArgs(cls(),
setter_name);
On 2015/09/03 20:48:49, hausner wrote:
> Extra space after =

Done.

https://codereview.chromium.org/1320673012/diff/1/runtime/vm/ast.cc#newcode695
runtime/vm/ast.cc:695: const String& getter_name =
On 2015/09/03 20:48:49, hausner wrote:
> Is getter_name_ guaranteed to be non-null? If not, handle the case.

The assert below says getter must exist. Adding ASSERT(!getter_name.IsNull());

[srdjan, 2015-09-03 21:09:49]

Committed patchset #2 (id:20001) manually as
d4365bc6f41a13f6c76bd27503b16f2f7ceae12c (presubmit successful).