runtime/lib/integers.cc - Issue 1320673012: Lookup getter/setter symbols before alllocating them, thus eliminating extra String allocations in …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/integers.cc

Issue 1320673012: Lookup getter/setter symbols before alllocating them, thus eliminating extra String allocations in … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Formatting Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/integers.cc

diff --git a/runtime/lib/integers.cc b/runtime/lib/integers.cc

index 1ee5b2511bf078a681eeb5ded59def1fe1cb8c95..b1ca62c3e311877ca86ac568531c416d42b56f18 100644

--- a/runtime/lib/integers.cc

+++ b/runtime/lib/integers.cc

@@ -261,7 +261,7 @@ static RawInteger* ShiftOperationHelper(Token::Kind kind,

}

if (value.IsSmi()) {

const Smi& smi_value = Smi::Cast(value);

- return smi_value.ShiftOp(kind, amount, silent);

+ return smi_value.ShiftOp(kind, amount, Heap::kNew, silent);

}

if (value.IsMint()) {

const int64_t mint_value = value.AsInt64Value();

« no previous file with comments | « no previous file | runtime/vm/ast.cc » ('j') | no next file with comments »