Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: runtime/vm/object_test.cc

Issue 1320673012: Lookup getter/setter symbols before alllocating them, thus eliminating extra String allocations in … (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Formatting Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index 5e006a0855fed675d15abee2d08c4d06c4796ac3..692a03bf22b800d7e882c708b7843d1b33f15252 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -4779,6 +4779,14 @@ TEST_CASE(Symbols_FromConcatAll) {
const String* data[3] = { &str1, &Symbols::Dot(), &str2 };
CheckConcatAll(data, 3);
}
+
+ {
+ const String& empty = String::Handle(String::New(""));
+ const String* data[3] = { &Symbols::FallThroughError(),
+ &empty,
+ &Symbols::isPaused() };
+ CheckConcatAll(data, 3);
+ }
}
} // namespace dart
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698