Lookup getter/setter symbols before alllocating them, thus eliminating extra String allocations in …

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 2965 matching lines @@
 
   // For static fields only. Constructs a closure that gets/sets the
   // field value.
   RawInstance* GetterClosure() const;
   RawInstance* SetterClosure() const;
   RawInstance* AccessorClosure(bool make_setter) const;
 
   // Constructs getter and setter names for fields and vice versa.
   static RawString* GetterName(const String& field_name);
   static RawString* GetterSymbol(const String& field_name);
+  // Returns String::null() if getter symbol does not exist.
+  static RawString* LookupGetterSymbol(const String& field_name);
   static RawString* SetterName(const String& field_name);
   static RawString* SetterSymbol(const String& field_name);
+  // Returns String::null() if setter symbol does not exist.
+  static RawString* LookupSetterSymbol(const String& field_name);
   static RawString* NameFromGetter(const String& getter_name);
   static RawString* NameFromSetter(const String& setter_name);
   static bool IsGetterName(const String& function_name);
   static bool IsSetterName(const String& function_name);
 
  private:
   friend class StoreInstanceFieldInstr;  // Generated code access to bit field.
 
   enum {
     kConstBit = 0,
@@ skipping 2611 matching lines @@
   // Returns 0, -1 or 1.
   virtual int CompareWith(const Integer& other) const;
 
   // Return the most compact presentation of an integer.
   RawInteger* AsValidInteger() const;
 
   // Returns null to indicate that a bigint operation is required.
   RawInteger* ArithmeticOp(Token::Kind operation,
                            const Integer& other,
                            Heap::Space space = Heap::kNew) const;
-  RawInteger* BitOp(Token::Kind operation, const Integer& other) const;
+  RawInteger* BitOp(Token::Kind operation,
+                    const Integer& other,
+                    Heap::Space space = Heap::kNew) const;
 
   // Returns true if the Integer does not fit in a Javascript integer.
   bool CheckJavascriptIntegerOverflow() const;
 
  private:
   OBJECT_IMPLEMENTATION(Integer, Number);
   friend class Class;
 };
 
 
@@ skipping 40 matching lines @@
   static intptr_t RawValue(intptr_t value) {
     return reinterpret_cast<intptr_t>(New(value));
   }
 
   static bool IsValid(int64_t value) {
     return (value >= kMinValue) && (value <= kMaxValue);
   }
 
   RawInteger* ShiftOp(Token::Kind kind,
                       const Smi& other,
+                      Heap::Space space = Heap::kNew,
                       const bool silent = false) const;
 
   void operator=(RawSmi* value) {
     raw_ = value;
     CHECK_HANDLE();
   }
   void operator^=(RawObject* value) {
     raw_ = value;
     CHECK_HANDLE();
   }
@@ skipping 2380 matching lines @@
 
 
 RawObject* MegamorphicCache::GetTargetFunction(const Array& array,
                                                intptr_t index) {
   return array.At((index * kEntryLength) + kTargetFunctionIndex);
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_