Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316123004: Improve display of simd vector types and stack traces in Observatory. (Closed)

Created:
5 years, 3 months ago by turnidge
Modified:
5 years, 3 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve display of simd vector types and stack traces in Observatory. Associated protocol changes. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7ac3150ee30b0e9f66acd716494774bfc5ae74f3

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -20 lines) Patch
M runtime/observatory/lib/src/elements/instance_ref.html View 1 2 3 2 chunks +19 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 chunks +23 lines, -12 lines 0 comments Download
M runtime/vm/service/service.md View 1 2 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
turnidge
5 years, 3 months ago (2015-08-26 20:14:45 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1316123004/diff/40001/runtime/observatory/lib/src/elements/instance_ref.html File runtime/observatory/lib/src/elements/instance_ref.html (right): https://codereview.chromium.org/1316123004/diff/40001/runtime/observatory/lib/src/elements/instance_ref.html#newcode15 runtime/observatory/lib/src/elements/instance_ref.html:15: .errorBox { .stacktraceBox ? https://codereview.chromium.org/1316123004/diff/40001/runtime/observatory/tests/ui/inspector.dart File runtime/observatory/tests/ui/inspector.dart (right): ...
5 years, 3 months ago (2015-08-26 20:54:20 UTC) #3
turnidge
https://codereview.chromium.org/1316123004/diff/40001/runtime/observatory/lib/src/elements/instance_ref.html File runtime/observatory/lib/src/elements/instance_ref.html (right): https://codereview.chromium.org/1316123004/diff/40001/runtime/observatory/lib/src/elements/instance_ref.html#newcode15 runtime/observatory/lib/src/elements/instance_ref.html:15: .errorBox { On 2015/08/26 20:54:20, rmacnak wrote: > .stacktraceBox ...
5 years, 3 months ago (2015-08-31 17:28:27 UTC) #4
turnidge
Committed patchset #4 (id:60001) manually as 7ac3150ee30b0e9f66acd716494774bfc5ae74f3 (presubmit successful).
5 years, 3 months ago (2015-08-31 17:34:59 UTC) #5
nweiz
On 2015/08/31 17:34:59, turnidge wrote: > Committed patchset #4 (id:60001) manually as > 7ac3150ee30b0e9f66acd716494774bfc5ae74f3 (presubmit ...
5 years, 3 months ago (2015-09-02 21:06:30 UTC) #6
nweiz
5 years, 3 months ago (2015-09-02 21:08:17 UTC) #7
Message was sent while issue was closed. 
On 2015/09/02 21:06:30, nweiz wrote:
> On 2015/08/31 17:34:59, turnidge wrote:
> > Committed patchset #4 (id:60001) manually as
> > 7ac3150ee30b0e9f66acd716494774bfc5ae74f3 (presubmit successful).
> 
> DBC: Should Error.stackTrace be documented as always being of kind StackTrace?

Actually, I guess that won't be true if it's a user class that implements
StackTrace. Never mind!

Powered by Google App Engine
This is Rietveld 408576698