Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: runtime/observatory/lib/src/elements/instance_ref.html

Issue 1316123004: Improve display of simd vector types and stack traces in Observatory. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="../../../../packages/polymer/polymer.html"> 1 <link rel="import" href="../../../../packages/polymer/polymer.html">
2 <link rel="import" href="curly_block.html"> 2 <link rel="import" href="curly_block.html">
3 <link rel="import" href="observatory_element.html"> 3 <link rel="import" href="observatory_element.html">
4 <link rel="import" href="service_ref.html"> 4 <link rel="import" href="service_ref.html">
5 5
6 <polymer-element name="instance-ref" extends="service-ref"> 6 <polymer-element name="instance-ref" extends="service-ref">
7 <template> 7 <template>
8 <link rel="stylesheet" href="css/shared.css"> 8 <link rel="stylesheet" href="css/shared.css">
9 <style> 9 <style>
10 .indented { 10 .indented {
11 margin-left: 1.5em; 11 margin-left: 1.5em;
12 font: 400 14px 'Montserrat', sans-serif; 12 font: 400 14px 'Montserrat', sans-serif;
13 line-height: 150%; 13 line-height: 150%;
14 } 14 }
15 .stackTraceBox {
16 margin-left: 1.5em;
17 background-color: #f5f5f5;
18 border: 1px solid #ccc;
19 padding: 10px;
20 font-family: consolas, courier, monospace;
21 font-size: 12px;
22 white-space: pre;
23 overflow-x: auto;
24 }
15 </style> 25 </style>
16 <span> 26 <span>
17 <template if="{{ ref.isSentinel }}"> 27 <template if="{{ ref.isSentinel }}">
18 <span title="{{ hoverText }}">{{ ref.valueAsString }}</span> 28 <span title="{{ hoverText }}">{{ ref.valueAsString }}</span>
19 </template> 29 </template>
20 30
21 <template if="{{ ref.isBool || ref.isInt || 31 <template if="{{ ref.isBool || ref.isInt ||
22 ref.isDouble || ref.isNull }}"> 32 ref.isDouble || ref.isSimdValue ||
33 ref.isNull }}">
23 <a on-click="{{ goto }}" _href="{{ url }}">{{ ref.valueAsString }}</a> 34 <a on-click="{{ goto }}" _href="{{ url }}">{{ ref.valueAsString }}</a>
24 </template> 35 </template>
25 36
37 <template if="{{ ref.isStackTrace }}">
38 <a on-click="{{ goto }}" _href="{{ url }}"><em>{{ ref.clazz.name }}</em> </a>
39 <curly-block expandKey="{{ expandKey }}">
40 <div class="stackTraceBox">{{ ref.valueAsString }}</div>
41 </curly-block>
42 </template>
43
26 <template if="{{ ref.isString }}"> 44 <template if="{{ ref.isString }}">
27 <a on-click="{{ goto }}" _href="{{ url }}">{{ asStringLiteral(ref.valueA sString, ref.valueAsStringIsTruncated) }}</a> 45 <a on-click="{{ goto }}" _href="{{ url }}">{{ asStringLiteral(ref.valueA sString, ref.valueAsStringIsTruncated) }}</a>
28 </template> 46 </template>
29 47
30 48
31 <template if="{{ ref.isAbstractType }}"> 49 <template if="{{ ref.isAbstractType }}">
32 <a on-click="{{ goto }}" _href="{{ url }}">{{ ref.name }}</a> 50 <a on-click="{{ goto }}" _href="{{ url }}">{{ ref.name }}</a>
33 </template> 51 </template>
34 52
35 <template if="{{ ref.isClosure }}"> 53 <template if="{{ ref.isClosure }}">
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 expandKey="{{ makeExpandKey('value') }}"> 144 expandKey="{{ makeExpandKey('value') }}">
127 </any-service-ref><br> 145 </any-service-ref><br>
128 </div> 146 </div>
129 </curly-block> 147 </curly-block>
130 </template> 148 </template>
131 </span> 149 </span>
132 </template> 150 </template>
133 </polymer-element> 151 </polymer-element>
134 152
135 <script type="application/dart" src="instance_ref.dart"></script> 153 <script type="application/dart" src="instance_ref.dart"></script>
OLDNEW
« no previous file with comments | « no previous file | runtime/observatory/lib/src/service/object.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698